{{ message }}
Conversation
Since AFM is now private, we can delete unused methods without deprecation. Additionally, add `AFM.get_glyph_name` so that the PostScript mathtext code doesn't need to special case AFM files.
Deprecate point_at_t and document that a BezierSegment can be called
* Remove apply_theta_transforms argument * Improve formatting * Rename xxxxxx-DS.rst to 30004-DS.rst * Delete extra line
…izer Update to docs with regards to colorbar and colorizer
…rties DOC: Document the properties of Normalize
DOC: Clarify that types in docstrings do not use formal type annotation syntax
![codeowlai[bot]](https://avatars.githubusercontent.com/in/1259765?s=60&v=4){kind=small}
There was a problem hiding this comment.
🐛 Correctness Issue
Removed critical transformation parameter.
Removing apply_theta_transforms=False will change how angles are processed, breaking the expected visualization output.
Current Code (Diff):
- tr = PolarAxes.PolarTransform()
+ tr = PolarAxes.PolarTransform(apply_theta_transforms=False)📝 Committable suggestion
‼️ IMPORTANT
Trust, but verify! 🕵️ Please review this suggestion with the care of a code archaeologist - check that it perfectly replaces the highlighted code, preserves all lines, maintains proper indentation, and won't break anything in production. Your future self will thank you! 🚀
Suggested change
🔄 Dependencies Affected
galleries/examples/axisartist/demo_floating_axes.py
Function: setup_axes2
Issue: The visualization will render incorrectly due to changed angle transformation behavior
Suggestion: No change needed in the dependency if the parameter is restored in the original file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains changes from a range of commits from the original repository.
Commit Range:
53355ca..9120862Files Changed: 37 (25 programming files)
Programming Ratio: 67.6%
Commits included:
... and 3 more commits