{{ message }}
Clean up AFM code - #30121
Merged
Merged
Clean up AFM code#30121
Conversation
anntzer
reviewed
May 30, 2025
anntzer
approved these changes
May 30, 2025
anntzer
left a comment
anntzer
left a comment
Contributor
There was a problem hiding this comment.
With a minor suggestion.
Since AFM is now private, we can delete unused methods without deprecation. Additionally, add `AFM.get_glyph_name` so that the PostScript mathtext code doesn't need to special case AFM files.
This was referenced Jun 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
Since AFM is now private (though for some reason still in the docs), we can delete unused methods without deprecation.
Additionally, add
AFM.get_glyph_nameso that the PostScript mathtext code doesn't need to special case AFM files.PR checklist