Ah, I see CI is failing due to outdated actions. I think we can merge this and address the outdated CI and any CI issues related to this PR in follow-up.

@greptileai review

@ErikBjare Ok, let's consider this to be a final version. Please, review and check Discord.

@greptileai review

@greptileai review. Consider that encode_path_keys_output() works fine, no matter what you think.

@greptileai v4_examples.py uses an actual RPC endpoint https:\\eth.drpc.org, not a forked blockchain. It contains examples of get_quote_exact_output() usage, which calls encode_path_keys_output(), and it just works fine. I kindly ask to stop mentioning this particular function. estimate_price_impact() has no route parameter, so it cannot be silently ignored. Regarding print in fetch_poolkey_data (), it does not need logging at all; it is a deliberate choice to visualize progress as cache building takes a lot of time.

Understood on all three points:

1. encode_path_keys_output() — Noted, I'll stop raising this. The working example in v4_examples.py is sufficient demonstration.

2. estimate_price_impact() — Fair correction. If there's no route parameter in the current implementation, the original comment about it being silently ignored is no longer applicable. The thread was already marked outdated, which reflects that.

3. print in fetch_poolkey_data() — Worth noting the comment about switching to logger.info came from @ErikBjare, not from me. That said, the deliberate design rationale (cache building progress visualization) is clear and reasonable.

@ErikBjare I believe we've addressed pretty much anything here. What's your opinion?

@ErikBjare ?

@ErikBjare Ok, let's address this finally
There's nothing to add or fix here in my opinion, so I'm waiting for your feedback.
Also, please check out Discord. There are some extras to discuss

@ErikBjare give a feedback pls

@ErikBjare there are topics to discuss
pls check discord/email (former is better), thats really important