Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.87%. Comparing base (f609454) to head (4d19b29).
⚠️ Report is 27 commits behind head on dev/v4-fin.

@@             Coverage Diff             @@
##           dev/v4-fin     #464   +/-   ##
===========================================
  Coverage       76.87%   76.87%           
===========================================
  Files              12       12           
  Lines            2249     2249           
===========================================
  Hits             1729     1729           
  Misses            520      520           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

Greptile Summary

This PR fixes a bug in position_manager_permit2_single() where the function was incorrectly constructing the permit call — it was wrapping astuple(permit_single) inside an extra outer tuple alongside a redundant spender and sig_deadline, which doesn't match the ABI's permit(address, PermitSingle, bytes) signature. The fix removes those duplicate parameters and passes astuple(permit_single) directly, since PermitSingle already encodes both spender and sig_deadline as its own fields.

• Bug fix: Removes spender and sig_deadline as standalone function parameters and stops wrapping them in an outer tuple alongside astuple(permit_single), aligning the call with the ABI definition permit(address owner, PermitSingle permitSingle, bytes signature).
• Breaking signature change: Any existing callers of position_manager_permit2_single that relied on the old 6-argument form will need to be updated; however, the old form would have produced an ABI-encoding mismatch and reverted on-chain anyway.

Confidence Score: 5/5

Safe to merge — the change directly aligns the permit call with the on-chain ABI and removes arguments that were duplicated inside PermitSingle.

The fix is a targeted, well-justified correction. The old code wrapped astuple(permit_single) inside an extra outer tuple and repeated spender and sig_deadline as standalone arguments that were already encoded inside PermitSingle, causing an ABI mismatch that would always revert. The new call matches the ABI exactly: permit(address, PermitSingle, bytes). The change is narrow, the ABI confirms the expected shape, and the parallel batch function already used the correct pattern.

No files require special attention; the single changed method in uniswap4.py is straightforward and consistent with position_manager_permit2_batch.

Important Files Changed

Sequence Diagram

sequenceDiagram
    participant Caller
    participant uniswap4.py
    participant PositionManager (on-chain)
    participant Permit2 (on-chain)

    Caller->>uniswap4.py: position_manager_permit2_single(owner, permit_single, signature, payable_amount)
    note over uniswap4.py: astuple(permit_single)<br/>→ ((token, amount, expiration, nonce), spender, sig_deadline)
    uniswap4.py->>PositionManager (on-chain): permit(owner, PermitSingle, signature)
    PositionManager (on-chain)->>Permit2 (on-chain): forward permit call
    Permit2 (on-chain)-->>PositionManager (on-chain): success / err
    PositionManager (on-chain)-->>uniswap4.py: tx receipt
    uniswap4.py-->>Caller: HexBytes tx hash

_{Reviews (1): Last reviewed commit: "Fix position_manager_permit2_single()" | Re-trigger Greptile}