WIP: backport Go 1.26 bump#21417
Conversation
Backport of #19737. Creates a minimal Konflux pipeline that validates Go version compatibility by running 'go mod tidy' in the actual builder image. Adapted image refs to use rhel_8_golang_1.26 matching release-4.9. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Backport of #20291. The Konflux compatibility checks now validate Go version compatibility in the actual build environment, making the GOTOOLCHAIN=local simulation unnecessary. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Backport of #20750. Applies Go 1.26 compatibility fixes required after ROX-35288 bumped the compiler to 1.26.3: - URL parser: Go 1.26 validates port syntax before URL escapes - IPv6 validation: url.Parse now requires bracketed IPv6 per RFC 2732 - govet printf: %q → %v for []int (stricter format checking) - Goroutine scheduling: increased prune timeout for Go 1.26 scheduler - golangci: updated Go version to 1.26 - All tool go.mod files bumped to go 1.26.3 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
github-actions
Bot
added
area/central
area/operator
area/scanner
backport
janisz
added
the
auto-retest
|
Images are ready for the commit at 12f2024. To use with deploy scripts, first |
|
/konflux-retest scanner-v4-on-push |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-4.9 #21417 +/- ##
================================================
- Coverage 48.89% 47.74% -1.16%
================================================
Files 2719 779 -1940
Lines 202953 79042 -123911
================================================
- Hits 99244 37735 -61509
+ Misses 95947 37753 -58194
+ Partials 7762 3554 -4208
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
/konflux-retest scanner-v4-db-on-push |
|
/retest |
|
/konflux-retest operator-bundle-on-push |
2 similar comments
|
/konflux-retest operator-bundle-on-push |
|
/konflux-retest operator-bundle-on-push |
|
/retest |
|
/konflux-retest scanner-v4-on-push |
|
/konflux-retest main-on-push |
1 similar comment
|
/konflux-retest main-on-push |
|
@janisz: The following tests failed, say Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
2 participants
Description
Backports Go 1.26 compatibility fixes to release-4.9.
#21394 (ROX-35288) bumped the Go compiler and builder images to 1.26.3 on release-4.9, but did not include the code-level fixes required for Go 1.26 compatibility. This PR backports the remaining changes from three master PRs:
GOTOOLCHAIN=localenforcement from MakefilesChanges
Konflux Go validation pipeline (from #19737):
.konflux/konflux.check-go-builder-version.Dockerfile— validatesgo.modcompatibility against the builder image.tekton/checks.yaml— Tekton pipeline wiringrhel_8_golang_1.26image (release-4.9 uses rhel_8, not rhel_9 like master)GOTOOLCHAIN removal (from #20291):
GOTOOLCHAIN=localenforcement fromMakefileandscanner/Makefilegit diffcheck for CI to catch uncommittedgo mod tidyresultsGo 1.26 compatibility fixes (from #20750):
pkg/clientconn/client_test.go— URL parser error changed in Go 1.26 (port validation before URL escape)pkg/tlscheck/tlscheck_test.go— unbracketed IPv6 now rejected per RFC 2732pkg/env/integersetting.go—%q→%vfor[]int(stricter govet)central/processindicator/datastore/datastore_impl_test.go— prune timeout increase for Go 1.26 scheduler.golangci.yml— Go version1.25→1.26go.mod—go 1.25.0→go 1.26.3go.modfiles bumped to `go 1.26.3