{{ message }}
ROX-35006: Update Go 1.26#20750
Merged
Merged
Conversation
janisz
force-pushed
the
wip_bump_to_go_1.26
branch
from
87f1fa0 to
58db776
Compare
Contributor
janisz
force-pushed
the
wip_bump_to_go_1.26
branch
2 times, most recently
from
fc2686e to
1ec1982
Compare
Contributor
Author
|
/retest |
janisz
force-pushed
the
wip_bump_to_go_1.26
branch
from
e15aafa to
1504624
Compare
Contributor
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
github-actions
Bot
added
area/operator
konflux-build
janisz
added
the
auto-retest
Documents the complete process for upgrading Go versions in the StackRox project, including: - Files to update (go.mod, workflows, tool modules) - Expected test failures and how to fix them - CI infrastructure considerations (setup-go action, cache invalidation) - Konflux builder requirements - Common issues and solutions This guide captures lessons learned from the Go 1.26.2 upgrade, particularly the need for setup-go action when container has older Go version and the Konflux go-builder dependency. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Refactored the guide to be general documentation about Go upgrades rather than specific to 1.26.2: - Removed hardcoded version numbers, replaced with placeholders - Organized around principles and patterns rather than specific steps - Added comprehensive sections on: - Understanding test failure categories - CI infrastructure challenges and solutions - External build system dependencies - Best practices and security considerations - Expanded troubleshooting with root cause explanations - Made it clear what's StackRox-specific vs general Go concepts The guide now serves as evergreen documentation that applies to any future Go upgrade, with lessons learned from past upgrades informing the approach. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Go 1.26.2 changed the URL parser to validate port syntax before checking URL escapes. Updated error message expectation to match new behavior. Fixes WebSocket test failures in: - TestAuthenticatedHTTPTransport_WebSocket/invalid_wss - TestAuthenticatedHTTPTransport_WebSocket/invalid_ws Partially AI-generated
Go 1.26.3 is the latest patch release with the compiler and security fixes we need. The brew builder image (buildID 4026077) ships Go 1.26.3. Partially generated by AI Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Align all tools/*/go.mod with the main module Go version. Partially generated by AI Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Update openshift-golang-builder from rhel_9_golang_1.25 to rhel_9_golang_1.26 (brew buildID 4026077, Go 1.26.3). Partially generated by AI Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Align all operator/tools/*/go.mod with the target Go version. Partially generated by AI Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Was at go 1.24 with a stale toolchain directive. Partially generated by AI Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The guide duplicates information that belongs in commit messages and PR descriptions rather than a standalone document. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Five Konflux Dockerfiles still referenced rhel_9_golang_1.25. Updated to rhel_9_golang_1.26 (brew buildID 4026077) to match the builder already used in .konflux/ and .tekton/. Partially generated by AI Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Enable the modernize linter (previously disabled with TODO ROX-35007) and add newexpr to the disabled checks list alongside existing ones. Partially generated by AI Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Go 1.26 url.Parse rejects unbracketed IPv6 addresses. Instead of working around this, accept the stricter validation and require bracketed format (e.g. [2001:db8::1]:443). No real Docker registry endpoint uses unbracketed IPv6. Partially generated by AI Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-authored-by: Tomasz Janiszewski <janiszt@gmail.com>
janisz
force-pushed
the
wip_bump_to_go_1.26
branch
from
acd2588 to
4beb9b6
Compare
Contributor
|
/retest |
Contributor
|
/konflux-retest operator-bundle-on-push |
Contributor
|
/retest |
Contributor
|
/konflux-retest operator-index-on-push |
Contributor
Author
|
/konflux-retest operator-bundle-on-push |
1 similar comment
Contributor
Author
|
/konflux-retest operator-bundle-on-push |
Contributor
Author
|
/konflux-retest operator-index-on-push |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade Go from 1.25.8 to 1.26.3 across the entire codebase, including all tool modules, operator tool modules, Konflux/Tekton builder images, and scanner/hack/quay.
Changes
Version bumps
Fixes required for Go 1.26 compatibility
pkg/clientconn/client_test.go): Go 1.26 validates port syntax before checking URL escapes, changing the error priority. Updated test expectation from"invalid URL escape"to"invalid port after host".pkg/tlscheck/tlscheck.go): Go 1.26'surl.Parse()now requires IPv6 addresses to be bracketed per RFC 2732. StackRox accepts unbracketed IPv6 including ambiguousIPv6:portformats. Fixed by routing IPv6 addresses throughnetutil.ParseEndpoint()instead ofurl.Parse(), and adding explicit whitespace validation.pkg/env/integersetting.go): Changed%qto%vfor[]int—%qis for strings and Go 1.26's stricter govet catches the mismatch. (pkg/grpc/testutils.go): Added...when forwarding variadic arguments to prevent treating a slice as a single argument.central/processindicator/datastore/datastore_impl_test.go): IncreasedWaitWithTimeoutfrom3*prunePeriod(300ms) to5*prunePeriod(500ms) on the prune path that includes a DB delete — the slowest path that's sensitive to Go 1.26's scheduling changes.