refactor(cli): split orchestration handlers by domain by nwparker · Pull Request #16139 · stablyai/orca · GitHub
Skip to content

refactor(cli): split orchestration handlers by domain - #16139

Merged
nwparker merged 1 commit into
stablyai:mainfrom
nwparker:nwparker/less-big-3
Aug 25, 2026
Merged

nwparker merged 1 commit into
stablyai:mainfrom
nwparker:nwparker/less-big-3

Conversation

@nwparker

Copy link
Copy Markdown
Contributor

Summary

  • split the 1,327-line orchestration CLI handler into 19 concretely named domain modules
  • preserve the public lazy import, all 29 command bodies, canonical registration order, RPC parameters, output, exit codes, cleanup, and compatibility fallbacks
  • remove the max-lines suppression and ratchet baseline entry; every production module is at most 137 effective lines
  • add boundary tests for parser/formatting behavior, dispatch composition, and handler order
  • introduce no barrel exports or vague helper/common modules

Verification

  • 19 focused test files: 191 tests passed
  • changed-file oxlint passed
  • CLI typecheck passed
  • max-lines ratchet passed with one fewer grandfathered entry
  • CLI build and executable verification passed
  • two independent regression reviews found no findings; handler and helper bodies were compared against origin/main
  • broad suite: 57,563 passed; load-sensitive failures were isolated. Cookie, transcript, filesystem watcher, palette, and startup-budget suites passed serially. The remaining worktree-poller timing and SSH mock failures reproduce unchanged on exact origin/main.

Compatibility review

Checked macOS/Linux/Windows launcher behavior, SSH/folder execution boundaries, mixed runtime capability fallbacks, stale terminal reminting, retry receipts, partial worker settlement, keepalive cleanup, and JSON/text stdout/stderr contracts.

@coderabbitai

coderabbitai Bot commented Aug 23, 2026

Copy link
Copy Markdown
Contributor

@nwparker
nwparker merged commit 0b66daf into stablyai:main Aug 25, 2026
54 checks passed
paidaxingyo666 pushed a commit to paidaxingyo666/Manta that referenced this pull request Aug 25, 2026
dallascrilley pushed a commit to dallascrilley/orca that referenced this pull request Aug 27, 2026
enrick-dev pushed a commit to enrick-dev/orca that referenced this pull request Oct 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant