Complete twilio webhook by ivanma9 · Pull Request #233 · simstudioai/sim · GitHub
Skip to content

Complete twilio webhook#233

Closed
ivanma9 wants to merge 5 commits intosimstudioai:mainfrom
ivanma9:twilio-webhook
Closed

Complete twilio webhook#233
ivanma9 wants to merge 5 commits intosimstudioai:mainfrom
ivanma9:twilio-webhook

Conversation

@ivanma9
Copy link
Copy Markdown
Contributor

@ivanma9 ivanma9 commented Apr 7, 2025

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.
Solves issue #212. I wanted to make a way to trigger worflows that start from an SMS.

Fixes #212 (issue)

Type of change

With the correct configuration for Twilio, can trigger webflow from webhook via SMS

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • [ X] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Security enhancement
  • Performance improvement
  • Code refactoring (no functional changes)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.

Tested through logs and listeners from a registered Twilio account to test the phone number.
Make an account through Twilio. Make sure to set the ngrok url with the webhook endpoint from the twilio configuration on simstudio.
Send an SMS to that number.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • All tests pass locally and in CI (npm test)
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • I have updated version numbers as needed (if needed)

Security Considerations:

  • My changes do not introduce any new security vulnerabilities
  • I have considered the security implications of my changes

Additional Information:

Any additional information, configuration or data that might be necessary to reproduce the issue or use the feature.

@cubic-dev-ai
Copy link
Copy Markdown

cubic-dev-ai Bot commented Apr 7, 2025

@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 7, 2025

@ivanma9 is attempting to deploy a commit to the Sim Studio Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 7, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 15, 2025 6:51am

Copy link
Copy Markdown

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AI code reviewer found 9 issues

Comment thread sim/app/api/webhooks/test/[id]/route.ts Outdated
Comment thread sim/app/api/webhooks/test/[id]/route.ts Outdated
Comment thread sim/package.json
"uuid": "^11.1.0",
"zod": "^3.24.2"
"zod": "^3.24.2",
"zustand": "^5.0.3"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Zustand is already used extensively in the codebase but was missing from package.json dependencies, suggesting this PR is fixing an undeclared dependency.

Comment thread sim/app/api/webhooks/trigger/[path]/route.ts Outdated
Comment thread sim/app/api/webhooks/test/[id]/route.ts Outdated
@waleedlatif1
Copy link
Copy Markdown
Collaborator

@ivanma9 please resolve the merge conflicts and make the PR again

@waleedlatif1 waleedlatif1 force-pushed the main branch 2 times, most recently from 2f7f9ba to 7604ecb Compare April 10, 2025 17:30
@emir-karabeg emir-karabeg force-pushed the main branch 5 times, most recently from 68794b3 to 41c5fb7 Compare April 14, 2025 08:36
@ivanma9
Copy link
Copy Markdown
Contributor Author

ivanma9 commented Apr 15, 2025

@waleedlatif1 waleedlatif1 force-pushed the main branch 10 times, most recently from a18a617 to b29827c Compare May 19, 2025 08:26
@waleedlatif1 waleedlatif1 force-pushed the main branch 2 times, most recently from 1b3f825 to b9b662b Compare May 21, 2025 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[REQUEST] SMS Twilio Webook

3 participants