PR Summary

Medium Risk
Touches core workflow state persistence/sync and edge validation logic across API, stores, and copilot operations; mistakes could drop edges/blocks or cause unexpected layout/selection behavior.

Overview
Introduces a shared normalizeWorkflowState pipeline and new validateEdges scope rules, and routes full-state writes (API state save, store replaceWorkflowState, socket replace-state, copilot load/apply) through it to drop invalid blocks/parentIds and remove dangling/scope-crossing/trigger-target edges while surfacing warnings.

Stabilizes copilot edits by preserving configured subblock types, normalizing condition/router branch IDs server-side, merging nestedNodes edits by name (instead of delete/recreate), deferring connection-to-edge creation until after ops, and adding targeted autolayout only for newly added/reparented blocks.

Improves canvas behavior for subflows and dynamic handles: subflow bodies no longer capture clicks (edges inside remain clickable), node z-index is computed consistently, shift-click multi-select now resolves parent/child conflicts, and dynamic condition/router handle topology is centralized (dynamic-handle-topology) with a new useDynamicHandleRefresh hook plus store syncing for remote subblock updates.

^{Written by Cursor Bugbot for commit 1bd97ff. Configure here.}

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
docs	Skipped		Mar 13, 2026 11:59pm

Greptile Summary

This PR introduces a unified workflow state normalization pipeline and several targeted fixes for subflow interaction, copilot stability, and dynamic handle topology. It's a substantial, well-structured improvement across the full stack.

Key changes:

• normalizeWorkflowState is now the single entry point for all full-state writes (hydration, copilot apply, socket sync, undo/redo), validating parentId integrity, stripping invalid/scope-crossing edges, and regenerating loop/parallel metadata from canonical block state.
• The copilot nestedNodes edit operation switches from delete-and-recreate to a name-based merge strategy, preserving child block IDs across edits and avoiding React Flow node remounts.
• normalizeConditionRouterIds assigns canonical block-scoped branch IDs server-side, removing the requirement for the LLM to produce correct internal handle IDs.
• useDynamicHandleRefresh centralises updateNodeInternals calls for condition/router blocks using topology signatures, replacing scattered setTimeout calls inside ConditionInput.
• The double-save race in the copilot diff store (broadcasting and persisting independently) is eliminated by removing the fire-and-forget persist path.
• Subflow background div is changed to pointer-events: none to let edges inside subflows receive clicks.

Confidence Score: 4/5

• Safe to merge with minor fixes; no critical logic regressions identified.
• The architecture is sound and well-tested. Two performance issues were found: a spurious blocks dependency in handleNodeClick that causes excessive callback re-creation on every block mutation, and unnecessary state-slice spreading in syncDynamicHandleSubblockValue that creates new edges/loops/parallels references on topology-only updates. A relative import in validation.ts also diverges from the established path-alias convention. None of these are functional regressions, but the first two can cause subtle re-render churn in the canvas.
• Pay close attention to apps/sim/stores/workflows/workflow/store.ts (syncDynamicHandleSubblockValue unnecessary spreading) and apps/sim/app/workspace/[workspaceId]/w/[workflowId]/workflow.tsx (handleNodeClick spurious blocks dependency).

Important Files Changed

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A["Full-state write trigger\n(hydration / copilot apply /\nsocket sync / undo-redo)"] --> B["normalizeWorkflowState()"]

    B --> B1["Validate blocks\n(type + name required)"]
    B1 --> B2["Validate parentIds\n(container exists, not self-ref)"]
    B2 --> B3["validateEdges()\nstrip missing / annotation /\ntrigger / scope-crossing edges"]
    B3 --> B4["generateLoopBlocks()\ngenerateParallelBlocks()"]
    B4 --> C["NormalizationResult\n{ state, warnings }"]

    C --> D["replaceWorkflowState()\nWorkflow Zustand store"]
    C --> E["DB persist\n(PUT /api/workflows/id/state)"]
    C --> F["Socket broadcast\nenqueueReplaceWorkflowState()"]

    G["Copilot edit-workflow tool"] --> H["applyOperationsToWorkflowState()\nPass 1: block ops\nPass 2: deferred edges\nPass 3: removeInvalidScopeEdges()"]
    H --> I["applyTargetedLayout()\nnew + repositioned blocks only"]
    I --> J["normalizeWorkflowState()\nfinal DB write"]
    J --> E

    K["SubBlock value change\n(conditions / routes)"] --> L["syncDynamicHandleSubblockValue()\nWorkflow store – topology only"]
    L --> M["collectDynamicHandleTopologySignatures()"]
    M --> N["useDynamicHandleRefresh()\nupdateNodeInternals() via rAF\nfor changed blocks"]

_{Last reviewed commit: 20312df}

bugbot run