{{ message }}
Repository navigation
fix(models): break circular import with Rekor clients - #1667
Closed
MatteoFari wants to merge 1 commit into
Closed
MatteoFari wants to merge 1 commit into
MatteoFari wants to merge 1 commit into
Conversation
Signed-off-by: Matteo Fari <matteofari06@gmail.com>
Author
Member
|
sorry, it's been a little busy. The PR moves the lazy imports to a different place -- maybe a slightly more appropriate one but it's still a lazy import to avoid the cycle, right? It's quite possible that there is no clean way to avoid lazy imports here but I'm not sure this is an improvement. |
Author
This was referenced Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fixes: #1536
This PR fixes the circular import that required lazy imports in sigstore.models after moving additional trust/config types into models.py.
Release Note
Fixed a circular import between sigstore.models and Rekor client modules, removing the need for lazy imports when constructing transparency log clients.
Documentation