fix lazy import in models.py · Issue #1536 · sigstore/sigstore-python · GitHub
Skip to content

fix lazy import in models.py #1536

Open

Description

@jku

#1496 moves more ClientTrustConfig and related classes (SigningConfig, TrustedRoot) to models. To accomodate that, lazy imports were added for RekorClient and Rekor2Client. It would be nice to clean this up.

The issue appears because we now import Rekor*Client in models but those want to import TransparencyLogEntry from models...

Activity

  1. MatteoFari commented on Jan 23, 2026

    @MatteoFari

    Hi @jku, I broke the cycle by removing the module-level TransparencyLogEntry import from the Rekor clients (kept under TYPE_CHECKING and imported locally where needed), so models.py can import Rekor clients normally. Let me know if I should change/improve something

  2. oaksprout commented on Jul 28, 2026

    @oaksprout
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions