add array_length function to BQL by tgpfeiffer · Pull Request #109 · sensorbee/sensorbee · GitHub
Skip to content

add array_length function to BQL #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nobu-k merged 2 commits into from
Jul 14, 2016
Merged

add array_length function to BQL #109

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1f6ee7e
add array_length function to BQL
tgpfeiffer Jul 12, 2016
7feed2c
implement array_length using UnaryFunc
tgpfeiffer Jul 14, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions bql/udf/builtin/array.go
View file
Open in desktop
82 changes: 82 additions & 0 deletions bql/udf/builtin/array_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,82 @@
package builtin

import (
"fmt"
. "github.com/smartystreets/goconvey/convey"
"gopkg.in/sensorbee/sensorbee.v0/bql/udf"
"gopkg.in/sensorbee/sensorbee.v0/data"
"math"
"testing"
"time"
)

func TestUnaryArrayFuncs(t *testing.T) {
someTime := time.Date(2015, time.May, 1, 14, 27, 0, 0, time.UTC)

invalidInputs := []udfUnaryTestCaseInput{
// NULL input -> NULL output
{data.Null{}, data.Null{}},
// cannot process the following
{data.Blob{}, nil},
{data.Bool(true), nil},
{data.Float(1.0), nil},
{data.Int(1), nil},
{data.Map{}, nil},
{data.String("hoge"), nil},
{data.Timestamp(someTime), nil},
}

udfUnaryTestCases := []udfUnaryTestCase{
{"array_length", arrayLengthFunc, []udfUnaryTestCaseInput{
{data.Array{}, data.Int(0)},
{data.Array{data.Int(2)}, data.Int(1)},
{data.Array{data.Null{}}, data.Int(1)},
{data.Array{data.Int(2), data.Float(3)}, data.Int(2)},
}},
}

for _, testCase := range udfUnaryTestCases {
f := testCase.f
allInputs := append(testCase.inputs, invalidInputs...)

Convey(fmt.Sprintf("Given the %s function", testCase.name), t, func() {
for _, tc := range allInputs {
tc := tc

Convey(fmt.Sprintf("When evaluating it on %s (%T)", tc.input, tc.input), func() {
val, err := f.Call(nil, tc.input)

if tc.expected == nil {
Convey("Then evaluation should fail", func() {
So(err, ShouldNotBeNil)
})
} else {
Convey(fmt.Sprintf("Then the result should be %s", tc.expected), func() {
So(err, ShouldBeNil)
if val.Type() == data.TypeFloat && tc.expected.Type() == data.TypeFloat {
fActual, _ := data.AsFloat(val)
fExpected, _ := data.AsFloat(tc.expected)
if math.IsNaN(fExpected) {
So(math.IsNaN(fActual), ShouldBeTrue)
} else {
So(val, ShouldAlmostEqual, tc.expected, 0.0000001)
}
} else {
So(val, ShouldResemble, tc.expected)
}
})
}
})
}

Convey("Then it should equal the one in the default registry", func() {
regFun, err := udf.CopyGlobalUDFRegistry(nil).Lookup(testCase.name, 1)
if dispatcher, ok := regFun.(*arityDispatcher); ok {
regFun = dispatcher.unary
}
So(err, ShouldBeNil)
So(regFun, ShouldHaveSameTypeAs, f)
})
})
}
}
2 changes: 2 additions & 0 deletions bql/udf/builtin/init.go
View file
Open in desktop