add array_length function to BQL by tgpfeiffer · Pull Request #109 · sensorbee/sensorbee · GitHub
Skip to content

add array_length function to BQL#109

Merged
nobu-k merged 2 commits into
sensorbee:masterfrom
tgpfeiffer:array_length
Jul 14, 2016
Merged

add array_length function to BQL#109
nobu-k merged 2 commits into
sensorbee:masterfrom
tgpfeiffer:array_length

Conversation

@tgpfeiffer

Copy link
Copy Markdown
Contributor

fixes #59

@nobu-k

nobu-k commented Jul 12, 2016

Copy link
Copy Markdown
Member

Comment thread bql/udf/builtin/array.go Outdated

@nobu-k nobu-k Jul 12, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about just define this as a function arrayLength and use udf.UnaryFunc to convert it to a UDF? Then, we can remove some error checks and a panic handling.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, rewrote using UnaryFunc.

@nobu-k nobu-k merged commit 0e1130d into sensorbee:master Jul 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement array_length function

2 participants