`conversation-activity-filter` - Fix sticky header overflow by SunsetTechuila · Pull Request #8966 · refined-github/refined-github · GitHub
Skip to content

conversation-activity-filter - Fix sticky header overflow - #8966

Merged
SunsetTechuila merged 18 commits into
mainfrom
filter-popover
Mar 11, 2026
Merged

SunsetTechuila merged 18 commits into
mainfrom
filter-popover

Conversation

@SunsetTechuila

@SunsetTechuila SunsetTechuila commented Feb 11, 2026 •

Copy link
Copy Markdown
Contributor

Fixes #8967

Depends on #8953

Please say this is reviewable as a single commit 🙏

Test URLs

#4008

#4030

Screenshot

image

@github-actions github-actions Bot added the bug label Feb 11, 2026
@fregante

Copy link
Copy Markdown
Member

@SunsetTechuila

SunsetTechuila commented Feb 11, 2026 •

Copy link
Copy Markdown
Contributor Author

This uses action-menu GitHub custom element, which uses the popover API

Example: https://github.com/refined-github/refined-github/releases/tag/26.2.2

image

@SunsetTechuila

Copy link
Copy Markdown
Contributor Author

Also see: #8806 (comment)

@SunsetTechuila
SunsetTechuila marked this pull request as ready for review February 26, 2026 16:45
@fregante

Copy link
Copy Markdown
Member

Can be merged as long as you tested it in a couple browsers and in "iPhone emulation" in Chrome. The main concern is how it behaves on touch/small viewports.

@SunsetTechuila

Copy link
Copy Markdown
Contributor Author
image

@fregante

Copy link
Copy Markdown
Member

@SunsetTechuila SunsetTechuila mentioned this pull request Mar 10, 2026
1 task done
@SunsetTechuila SunsetTechuila changed the title conversation-activity-filter - Use popover for menu conversation-activity-filter - Fix sticky header overflow Mar 11, 2026
@SunsetTechuila
SunsetTechuila merged commit c312944 into main Mar 11, 2026
8 checks passed
@SunsetTechuila
SunsetTechuila deleted the filter-popover branch March 11, 2026 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

conversation-activity-filter - Sticky issue header can overflow viewport

2 participants