{{ message }}
Repository navigation
💯 Minor codebase updates and fixes #4008
Description
I'll use this issue to add small tasks that could be done, treat it as a wishlist or a good way to start getting acquainted with the codebase.
-
Find fickle selectors and change them with
select(something more specific).closest(the parent);GitHub has been removing some feature-specific classes like
.js-file-listwhich means that we end up with monstrosities likemain > :first-child .mt-1 .btnwhich mean nothing and could change at any time. Ideally instead we should find the best selector inside the target element (for example its icon,select('.octicon-branch[aria-label="Create branch"]')) and then reach the desired element with.closest('.btn'):- select('main > :first-child .mt-1 .btn') + select('.octicon-branch[aria-label="Create branch"]')!.closest('.btn')
-
Better yet: Replace
select().closest()calls with:has#4456
Activity
doc-han commentedon Feb 22, 2021
fregante commentedon Feb 22, 2021
cheap-glitch commentedon Mar 19, 2021
fregante commentedon Mar 19, 2021
yakov116 commentedon Mar 21, 2021
fregante commentedon Apr 2, 2021
yakov116 commentedon Apr 2, 2021
fregante commentedon Apr 3, 2021
fregante commentedon Apr 3, 2021
fregante commentedon Apr 3, 2021
fregante commentedon Apr 3, 2021
yakov116 commentedon Apr 6, 2021
26 remaining items
fregante commentedon Oct 7, 2021
cheap-glitch commentedon Oct 9, 2021
fregante commentedon Oct 13, 2021
fregante commentedon Nov 7, 2021
fregante commentedon Nov 9, 2021
[-]Minor codebase updates and fixes[/-][+]💯 Minor codebase updates and fixes[/+]fregante commentedon Dec 10, 2021
Let's not add any more requests to this issue. A new one can be created. We'll close this one after (almost) everything is done.
🛁 #5222
FloEdelmann commentedon Dec 16, 2021
fregante commentedon Dec 17, 2021
FloEdelmann commentedon Dec 17, 2021
fregante commentedon Jun 28, 2022
Closing and locking. Thanks for all the fish!