Simplify usage by supporting new default loop by clue · Pull Request #260 · reactphp/socket · GitHub
Skip to content

Simplify usage by supporting new default loop#260

Merged
clue merged 2 commits into
reactphp:masterfrom
clue-labs:default-loop
Jul 11, 2021
Merged

Simplify usage by supporting new default loop#260
clue merged 2 commits into
reactphp:masterfrom
clue-labs:default-loop

Conversation

@clue

@clue clue commented Jul 8, 2021

Copy link
Copy Markdown
Member

This changeset simplifies usage by supporting the new default loop.

// old (still supported)
$socket = new React\Socket\Server('127.0.0.1:8080', $loop);
$connector = new React\Socket\Connector($loop);

// new (using default loop)
$socket = new React\Socket\Server('127.0.0.1:8080');
$connector = new React\Socket\Connector();

Builds on top of reactphp/event-loop#226, reactphp/event-loop#229, reactphp/event-loop#232, reactphp/stream#159 and reactphp/dns#182

@clue clue added this to the v1.8.0 milestone Jul 8, 2021
@clue clue changed the title Simplify usage by supporting new default loop [WIP] Simplify usage by supporting new default loop Jul 8, 2021
@clue clue force-pushed the default-loop branch 3 times, most recently from 3c57fd1 to d52ab10 Compare July 8, 2021 14:08
@clue

clue commented Jul 8, 2021 •
edited
Loading

Copy link
Copy Markdown
Member Author

This was referenced Jul 8, 2021
Merged
Merged
Merged
@clue clue requested a review from WyriHaximus July 10, 2021 19:40
@clue clue mentioned this pull request Jul 10, 2021
Merged
@clue clue changed the title [WIP] Simplify usage by supporting new default loop Simplify usage by supporting new default loop Jul 11, 2021
@clue

clue commented Jul 11, 2021

Copy link
Copy Markdown
Member Author

@clue clue merged commit 991c1b6 into reactphp:master Jul 11, 2021
@clue clue deleted the default-loop branch July 11, 2021 12:49
This was referenced Jul 14, 2021
Merged
Merged
This was referenced Jul 14, 2021
Merged
Merged
Merged
This was referenced Jul 22, 2021
Merged
Merged
Merged
Merged
Merged
@SimonFrings SimonFrings mentioned this pull request Jul 28, 2021
Merged
@clue clue mentioned this pull request Aug 1, 2021
Merged
@SimonFrings SimonFrings mentioned this pull request Aug 2, 2021
Merged
@clue clue mentioned this pull request Aug 30, 2021
Merged
@SimonFrings SimonFrings mentioned this pull request Jan 13, 2022
Merged
This was referenced Jul 4, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@WyriHaximus WyriHaximus WyriHaximus approved these changes

Assignees

No one assigned

Labels

new feature

Projects

None yet

Milestone

v1.8.0

Development

Successfully merging this pull request may close these issues.

2 participants

@clue @WyriHaximus