Simplify usage by supporting new default loop by clue · Pull Request #410 · reactphp/http · GitHub
Skip to content

Simplify usage by supporting new default loop#410

Merged
clue merged 3 commits into
reactphp:masterfrom
clue-labs:default-loop
Jul 11, 2021
Merged

Simplify usage by supporting new default loop#410
clue merged 3 commits into
reactphp:masterfrom
clue-labs:default-loop

Conversation

@clue

@clue clue commented Jul 8, 2021 •
edited
Loading

Copy link
Copy Markdown
Member

This changeset simplifies usage by supporting the new default loop.

// old (still supported)
$browser = new React\Http\Browser($loop);
$server = new React\Http\Server($loop, $handler);

// new (using default loop)
$browser = new React\Http\Browser();
$server = new React\Http\Server($handler);

Builds on top of reactphp/event-loop#226, reactphp/event-loop#229, reactphp/event-loop#232, reactphp/stream#159, reactphp/dns#182 and reactphp/socket#260
Refs #361

@clue clue added this to the v1.4.0 milestone Jul 8, 2021
@clue

clue commented Jul 8, 2021

Copy link
Copy Markdown
Member Author

This was referenced Jul 9, 2021
Merged
Merged
@clue clue requested a review from WyriHaximus July 10, 2021 19:40
@clue clue mentioned this pull request Jul 10, 2021
Merged
@clue clue changed the title [WIP] Simplify usage by supporting new default loop Simplify usage by supporting new default loop Jul 11, 2021
@clue

clue commented Jul 11, 2021

Copy link
Copy Markdown
Member Author

@clue clue merged commit f37c964 into reactphp:master Jul 11, 2021
@clue clue deleted the default-loop branch July 11, 2021 13:02
This was referenced Jul 15, 2021
Merged
Merged
This was referenced Jul 21, 2021
Merged
Merged
Merged
Merged
Merged
Merged
@clue clue mentioned this pull request Aug 7, 2021
Merged
@clue clue mentioned this pull request Oct 18, 2021
Merged
@clue clue mentioned this pull request Jan 23, 2022
Merged
@clue clue mentioned this pull request Aug 9, 2022
Merged
This was referenced Aug 9, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@WyriHaximus WyriHaximus WyriHaximus approved these changes

Assignees

No one assigned

Labels

new feature

Projects

None yet

Milestone

v1.4.0

Development

Successfully merging this pull request may close these issues.

2 participants

@clue @WyriHaximus