{{ message }}
custom comparator support in calculate_numeric_gap#15969
Merged
Conversation
meta-cla
Bot
added
the
CLA Signed
Contributor
|
@Gasoonjia has exported this pull request. If you are a Meta employee, you can view the originating Diff in D87840446. |
kimishpatel
approved these changes
Nov 25, 2025
winskuo-quic
left a comment
winskuo-quic
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for supporting this feature and providing users more flexibility!
| Args: | ||
| distance: The metrics the inspector will use for gap calculation. Should be one of "MSE", "L1" and "SNR". | ||
| distance: The metrics the inspector will use for gap calculation. Can be either: | ||
| - A string: one of "MSE", "L1", or "SNR" for built-in comparators. |
Collaborator
There was a problem hiding this comment.
Should this be - A string: one of "MSE", "L1", "SNR", or user-defined comparators?
Contributor
Author
There was a problem hiding this comment.
i separated the bulit-in comparators and custom comparators into two lines
facebook-github-bot
pushed a commit
that referenced
this pull request
Nov 25, 2025
Summary: Enable users to define their own metrics for numeric gap. Differential Revision: D87840446
facebook-github-bot
force-pushed
the
export-D87840446
branch
from
a730526 to
68cde50
Compare
facebook-github-bot
pushed a commit
that referenced
this pull request
Dec 1, 2025
Summary: Enable users to define their own metrics for numeric gap. Differential Revision: D87840446
facebook-github-bot
force-pushed
the
export-D87840446
branch
from
68cde50 to
406a4e7
Compare
Summary: Enable users to define their own metrics for numeric gap. Differential Revision: D87840446
facebook-github-bot
force-pushed
the
export-D87840446
branch
from
406a4e7 to
ffb03ca
Compare
AdrianLundell
pushed a commit
to AdrianLundell/executorch
that referenced
this pull request
Dec 2, 2025
Differential Revision: D87840446 Pull Request resolved: pytorch#15969
jirioc
pushed a commit
to nxp-upstream/executorch
that referenced
this pull request
Dec 19, 2025
Differential Revision: D87840446 Pull Request resolved: pytorch#15969
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Enable users to define their own metrics for numeric gap.
Differential Revision: D87840446