{{ message }}
Add SBOMs generation for Windows artifacts - #99
Closed
sethmlarson wants to merge 1 commit into
Closed
Conversation
sethmlarson
changed the title
Member
zooba
reviewed
Feb 22, 2024
| - powershell: > | ||
| python | ||
| "$(Build.SourcesDirectory)\sbom.py" | ||
| (gci msi\*\python-*.exe | select -First 1) |
Member
There was a problem hiding this comment.
Any reason we wouldn't/shouldn't just do all of them? (Omitting the select -First 1 should pass them all as separate args, and then sys.argv[1:] in Python can get them all.)
Comment on lines
+41
to
+45
| - task: PublishPipelineArtifact@0 | ||
| displayName: 'Publish artifact: sbom' | ||
| inputs: | ||
| targetPath: '$(Build.BinariesDirectory)\sbom' | ||
| artifactName: sbom |
Member
There was a problem hiding this comment.
Suggested change
| - task: PublishPipelineArtifact@0 | |
| displayName: 'Publish artifact: sbom' | |
| inputs: | |
| targetPath: '$(Build.BinariesDirectory)\sbom' | |
| artifactName: sbom | |
| - publish: '$(Build.BinariesDirectory)\sbom' | |
| artifact: sbom | |
| displayName: 'Publish artifact: sbom' |
This is the preferred format for simple cases now (should auto-update when they need to make changes to the publish task).
| dependsOn: ['Test_MSI', 'Test'] | ||
| dependsOn: ['SBOM', 'Test_MSI', 'Test'] | ||
| jobs: | ||
| - template: stage-publish-pythonorg.yml |
Member
There was a problem hiding this comment.
I assume we're going to get chances to this template as well to SSH the files up to the server?
Collaborator
Author
There was a problem hiding this comment.
Yeah that's the plan, I might do that in a follow-up PR though. Maybe I'll remove this dependsOn for now.
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires python/cpython#115789 to be checked in to work.
checkout.ymlessentially pull CPython's source code into therelease-toolsdirectory?ensurepipfor the embed artifactsmasterso I can test this code before enabling it for future releases?cc @zooba