{{ message }}
gh-112844: Add SBOM for external dependencies - #115789
Merged
Merged
Conversation
Member
This was referenced Feb 22, 2024
hugovk
approved these changes
Feb 28, 2024
zooba
reviewed
Feb 28, 2024
Member
|
LGTM |
Member
|
@sethmlarson Ready to merge this? |
Contributor
Author
|
@hugovk Ready to merge! |
|
Thanks @sethmlarson for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 29, 2024
(cherry picked from commit 45d8871) Co-authored-by: Seth Michael Larson <seth@python.org>
hugovk
pushed a commit
that referenced
this pull request
Feb 29, 2024
woodruffw
pushed a commit
to woodruffw-forks/cpython
that referenced
this pull request
Mar 4, 2024
adorilson
pushed a commit
to adorilson/cpython
that referenced
this pull request
Mar 25, 2024
diegorusso
pushed a commit
to diegorusso/cpython
that referenced
this pull request
Apr 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an SBOM and tooling for dependencies specified in
get_externals.batfor Windows builds. This SBOM will be picked up byrelease-toolsto generated SBOMs for Windows artifacts.One question I had was whether we should handle our "patched" versions of dependencies, and if so if there was any known way for this tool to detect that (short of tracking it ourselves).