{{ message }}
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fyi, if
FORCE_COLORis used for a different purpose (e.g. a different python library), it could contain a string, and this would raise an error.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, would be better to just check whether
FORCE_COLORexists, with any value (even 0!).Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
...Really? If somebody puts
FORCE_COLOR: 0in a GitHub Actions workflow, they expect it to force color??There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From a review of the Python projects @hugovk linked to in #13806 (comment), it looks like the answer is: yup!
toxis the only project on that list that will treatFORCE_COLOR: 0as indicating that the user does not want color.Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FORCE_COLORenvironment variable match the emerging standard #13853Thanks for flagging this @nnrepos!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AlexWaygood thanks, but this is not what i was talking about. i was talking about a possible
ValueErrorin case the variable is not a number (e.g.False).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that's what
NO_COLORdoes! 😅https://no-color.org/
Here's how pytest does it:
https://github.com/pytest-dev/pytest/blob/b7d4de1ea983d3c4d3d9e235f63942abc6bfb167/src/_pytest/_io/terminalwriter.py#L26-L37
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I understood! #13853 means that you won't get a
ValueErrorforFORCE_COLORif you provide a value for that variable that can't be passed to theint()constructor. (It preserves the behaviour forMYPY_FORCE_COLORthat was present prior to this PR, however, since that's longstanding behaviour, and "fixing" it might be a breaking change in some ways.)#13853 looks like it might be rejected, though, so this may be a moot point :)