{{ message }}
Make handling of FORCE_COLOR environment variable match the emerging standard - #13853
Closed
AlexWaygood wants to merge 1 commit into
Closed
AlexWaygood wants to merge 1 commit into
AlexWaygood wants to merge 1 commit into
Conversation
Contributor
JelleZijlstra
approved these changes
Oct 9, 2022
Collaborator
There was a problem hiding this comment.
Unless there's actually some thought out standard and not just tired maintainers merging quick PRs, let's treat FORCE_COLOR=0 as not forcing colour. Setting env vars to 0 or 1 is about as standard as it gets and it's weird that it's inconsistent with MYPY_FORCE_COLOR. Also looks like it's not just tox, it's node too.
Member
Author
Yeah, that's fair. I don't really have a strong opinion one way or another :) @hugovk might have some thoughts! |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See the conversation in https://github.com/python/mypy/pull/13814/files#r990652344: the emerging standard for this is to treat the presence of the
FORCE_COLORenvironment variable as indicating that color is desired, even if the variable is set to"0"or"False". This PR makes mypy's behaviour here match the behaviour ofpytest,nox,richandpypa/buildin how they all handle this environment variable.(It doesn't match the behaviour of
tox, buttoxseems to be on its own here.)