bpo-45403: Fix test_sys.test_stdlib_dir() by vstinner · Pull Request #28785 · python/cpython · GitHub
Skip to content

bpo-45403: Fix test_sys.test_stdlib_dir() - #28785

Merged
vstinner merged 1 commit into
python:mainfrom
vstinner:test_stdlib_dir
Oct 7, 2021
Merged

bpo-45403: Fix test_sys.test_stdlib_dir()#28785
vstinner merged 1 commit into
python:mainfrom
vstinner:test_stdlib_dir

Conversation

@vstinner

@vstinner vstinner commented Oct 7, 2021 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

Fix test_sys.test_stdlib_dir() when Python is built outside the
source tree: compare normalized paths.

https://bugs.python.org/issue45403

@vstinner
bpo-45403: Fix test_sys.test_stdlib_dir()
4537c29 
Fix test_sys.test_stdlib_dir() when Python is built outside the
source tree: compare normalized paths.
@bedevere-bot bedevere-bot added the tests Tests in the Lib/test dir label Oct 7, 2021
@vstinner

vstinner commented Oct 7, 2021

Copy link
Copy Markdown
Member Author

@ericsnowcurrently

ericsnowcurrently commented Oct 7, 2021

Copy link
Copy Markdown
Member

I propose to fix the test, we can revisit normalization during Python startup later.

You may want to have a chat with @zooba, who has been threatening to make getpath.c pure Python (frozen). 🙂

ericsnowcurrently
ericsnowcurrently approved these changes Oct 7, 2021
View reviewed changes

@ericsnowcurrently ericsnowcurrently left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks for doing this.

@ericsnowcurrently

ericsnowcurrently commented Oct 7, 2021

Copy link
Copy Markdown
Member

@vstinner, do we have a buildbot for out-of-tree builds? Clearly I've missed cases where I broke that with some of my recent work.

@vstinner

vstinner commented Oct 7, 2021

Copy link
Copy Markdown
Member Author

You may want to have a chat with @zooba, who has been threatening to make getpath.c pure Python (frozen). slightly_smiling_face

I rewrote getpath.c in pure Python: #23169

But it changes the behavior, Nick Coghlan requested a PEP. I wasn't very motivated. I abandonned my PR.

@vstinner

vstinner commented Oct 7, 2021

Copy link
Copy Markdown
Member Author

@vstinner, do we have a buildbot for out-of-tree builds? Clearly I've missed cases where I broke that with some of my recent work.

It seems like we don't. The issue was catched by my colleague Miro @hroncok when he built the Fedora Python 3.11.0a1 package.

@vstinner
vstinner merged commit 768aaf6 into python:main Oct 7, 2021
@vstinner
vstinner deleted the test_stdlib_dir branch October 7, 2021 19:22
@bedevere-bot

bedevere-bot commented Oct 7, 2021

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericsnowcurrently ericsnowcurrently ericsnowcurrently approved these changes

Assignees

No one assigned

Labels

tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vstinner @ericsnowcurrently @bedevere-bot @the-knights-who-say-ni