[WIP] bpo-42260: Rewrite getpath.c in Python by vstinner · Pull Request #23169 · python/cpython · GitHub
Skip to content

[WIP] bpo-42260: Rewrite getpath.c in Python - #23169

Closed
vstinner wants to merge 2 commits into
python:mainfrom
vstinner:getpath_py
Closed

[WIP] bpo-42260: Rewrite getpath.c in Python#23169
vstinner wants to merge 2 commits into
python:mainfrom
vstinner:getpath_py

Conversation

@vstinner

@vstinner vstinner commented Nov 5, 2020

Copy link
Copy Markdown
Member
  • Add _getpath Python module and _cgetpath C module
  • Py_SetPath() no longer computes the path configuration.

https://bugs.python.org/issue42260

@vstinner

vstinner commented Nov 5, 2020

Copy link
Copy Markdown
Member Author

@vstinner

vstinner commented Nov 5, 2020

Copy link
Copy Markdown
Member Author

* Add _getpath Python module and _cgetpath C module
* Py_SetPath() no longer computes the path configuration.
* _PyErr_SetFromPyStatus() now raises SystemExit if the status is an
  exit code.
Also move PathConfig class
@vstinner

Copy link
Copy Markdown
Member Author

Remaining issue: test_init_read_set() fails. The error on Windows is different than the error on Linux/macOS.

Windows:

-  'base_executable': 'D:\\a\\cpython\\cpython\\PCbuild\\amd64\\_testembed.exe',
+  'base_executable': 'my_executable',

Linux/macOS:


   'module_search_paths': ['/opt/python-dev/lib/python310.zip',
-                          'Lib',
?                           ^ ^

+                          'test_path_insert1',
?                           ^^^^^^^^^^ ^^^^^^

+                          '/Users/runner/work/cpython/cpython/Lib',
-                          'build/lib.macosx-10.15-x86_64-3.10-pydebug'],
?                                                                      -

+                          '/Users/runner/work/cpython/cpython/build/lib.macosx-10.15-x86_64-3.10-pydebug',
?                           +++++++++++++++++++++++++++++++++++

+                          'test_path_append'],

@github-actions

Copy link
Copy Markdown

@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Dec 26, 2020
@vstinner vstinner closed this Sep 21, 2021
@vstinner
vstinner deleted the getpath_py branch September 21, 2021 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting core review stale Stale PR or inactive for long period of time.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants