Rename Doc/README.txt to Doc/README.rst#19
Conversation
| echo. | ||
| echo.All arguments past the first one are passed through to sphinx-build as | ||
| echo.filenames to build or are ignored. See README.txt in this directory or | ||
| echo.filenames to build or are ignored. See README.rst in this directory or |
There was a problem hiding this comment.
This PR renames Doc/README.txt to Doc/README.rst.
There was a problem hiding this comment.
Ah, I'm sorry. I misundersttod.
| echo. | ||
| echo.All arguments past the first one are passed through to sphinx-build as | ||
| echo.filenames to build or are ignored. See README.txt in this directory or | ||
| echo.filenames to build or are ignored. See README.rst in this directory or |
There was a problem hiding this comment.
Ah, I'm sorry. I misundersttod.
|
I think we don't require CLA sign for pull requests like this. |
|
@methane , any patch / contribution requires CLA sign. |
|
I signed it an hour ago. |
|
vstinner
left a comment
There was a problem hiding this comment.
I suggest to take the opportunity of this change to not only rename README.txt to README.rst but also make some reST syntax enhancements like using reST syntax for links.
|
@methane MY CLA still has not been marked, and I currently have this: It's been two days since I submitted it, any update? |
|
Why was this change tagged as "backport to 3.6"? Was it made in the 3.6 branch? If yes, please redo it in the master branch. |
|
No, it was made in the master branch @Haypo |
|
@Haypo Can you give me an example as to how you would like the link formatted? I'm more used to writing in markdown than I am in reST |
Look at README.rst in the root directory. |
vstinner
left a comment
There was a problem hiding this comment.
I suggested different text where [...] is the link.
|
|
||
| Bugs in the toolset should be reported in the Sphinx bug tracker at | ||
| https://www.bitbucket.org/birkenfeld/sphinx/issues/. | ||
| `bitbucket.org/birkenfeld/sphinx/issues/ <https://www.bitbucket.org/birkenfeld/sphinx/issues/>`_. |
There was a problem hiding this comment.
I suggest "Bugs in the toolset should be reported in the [Sphinx bug tracker]."
| @@ -109,10 +109,10 @@ Contributing | |||
| ============ | |||
|
|
|||
| Bugs in the content should be reported to the Python bug tracker at | |||
There was a problem hiding this comment.
"Bugs in the content should be reported to the [Python bug tracker]."
| You need to have `Sphinx <http://sphinx-doc.org/>`_ installed; it is the toolset | ||
| used to build the docs. It is not included in this tree, but maintained | ||
| separately and available from PyPI <https://pypi.python.org/pypi/Sphinx>. | ||
| separately and available from `PyPI <https://pypi.python.org/pypi/Sphinx>`_. |
| This directory contains the reStructuredText (reST) sources to the Python | ||
| documentation. You don't need to build them yourself, prebuilt versions are | ||
| available at <https://docs.python.org/dev/download.html>. | ||
| available at `docs.python.org/dev/download.html <https://docs.python.org/dev/download.html>`_. |
There was a problem hiding this comment.
..., [prebuilt versions are available].
|
The reason the CLA bot is not showing me as signed is probably because I used the online editor for the original commit (which commits under the noreply@github address). My email address is |
Codecov Report
@@ Coverage Diff @@
## master #19 +/- ##
==========================================
- Coverage 82.37% 82.37% -0.01%
==========================================
Files 1427 1427
Lines 350948 350948
==========================================
- Hits 289091 289089 -2
- Misses 61857 61859 +2Continue to review full report at Codecov.
|
Fix venvlauncher
19: Warn for range and xrange r=ltratt a=nanjekyejoannah See notes: ``` Py2.x: >>> x = xrange(1, 10000) >>> a = range(1,10000) >>> type(a) <type 'list'> >>> Py3.x: >>> x = xrange(1, 10000) Traceback (most recent call last): File "<stdin>", line 1, in <module> NameError: name 'xrange' is not defined >>> a = range(1,10000) >>> type(a) <class 'range'> >>> ``` Co-authored-by: Joannah Nanjekye <jnanjekye@python.org>
* fix: off by one error in forward jump calculation * Test: fixed test for python#18 * test: remove broken test --------- Co-authored-by: Jules <julia.poo.poo.poo@gmail.com>
There are still some issues with compilation, but those can be sorted out in a future PR.


I have simply updated the document and its references to README.rst (thanks to whoever formatted it).