bpo-40958: Avoid buffer overflow in the parser when indexing the current line by pablogsal · Pull Request #20842 · python/cpython · GitHub
Skip to content

bpo-40958: Avoid buffer overflow in the parser when indexing the current line#20842

Closed
pablogsal wants to merge 2 commits intopython:masterfrom
pablogsal:bpo-40958
Closed

bpo-40958: Avoid buffer overflow in the parser when indexing the current line#20842
pablogsal wants to merge 2 commits intopython:masterfrom
pablogsal:bpo-40958

Conversation

@pablogsal
Copy link
Copy Markdown
Member

@pablogsal pablogsal commented Jun 12, 2020 •
edited by bedevere-bot
Loading

@pablogsal pablogsal requested a review from lysnikolaou June 12, 2020 21:18
@pablogsal
Copy link
Copy Markdown
Member Author

pablogsal commented Jun 12, 2020 •
edited
Loading

@pablogsal pablogsal self-assigned this Jun 12, 2020
tiran
tiran requested changes Jun 12, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@tiran tiran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A test is failing:

 ======================================================================
FAIL: testSyntaxErrorOffset (test.test_exceptions.ExceptionTests) (source=b'Python = "\xcf\xb3\xf2\xee\xed" +', lineno=1, offset=18)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "D:\a\cpython\cpython\lib\test\test_exceptions.py", line 188, in check
    self.assertEqual(cm.exception.offset, offset)
AssertionError: 13 != 18

@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Jun 12, 2020

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

lysnikolaou
lysnikolaou reviewed Jun 12, 2020
View reviewed changes
Comment thread Parser/pegen.c Outdated
@pablogsal
Copy link
Copy Markdown
Member Author

pablogsal commented Jun 12, 2020

Closing this as this is missing something important and unfortunately, I don't have time to investigate today :(

@pablogsal pablogsal closed this Jun 12, 2020
@pablogsal
Copy link
Copy Markdown
Member Author

pablogsal commented Jun 12, 2020

@lysnikolaou Feel free to investigate if you have some time

@lysnikolaou
Copy link
Copy Markdown
Member

lysnikolaou commented Jun 12, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lysnikolaou lysnikolaou lysnikolaou left review comments

@tiran tiran tiran requested changes

Assignees

@pablogsal pablogsal

Labels

awaiting changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@pablogsal @bedevere-bot @lysnikolaou @tiran @the-knights-who-say-ni