bpo-38478: Correctly handle keyword argument with same name as positional-only parameter by pablogsal · Pull Request #16800 · python/cpython · GitHub
Skip to content

bpo-38478: Correctly handle keyword argument with same name as positional-only parameter - #16800

Merged
pablogsal merged 1 commit into
python:masterfrom
pablogsal:bpo-38478
Oct 15, 2019
Merged

bpo-38478: Correctly handle keyword argument with same name as positional-only parameter#16800
pablogsal merged 1 commit into
python:masterfrom
pablogsal:bpo-38478

Conversation

@pablogsal

@pablogsal pablogsal commented Oct 15, 2019 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

@pablogsal pablogsal self-assigned this Oct 15, 2019
@pablogsal

pablogsal commented Oct 15, 2019 •
edited
Loading

Copy link
Copy Markdown
Member Author

tirkarthi
tirkarthi approved these changes Oct 15, 2019
View reviewed changes

@tirkarthi tirkarthi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I too had the same solution in mind since it's simple . Thanks Pablo :)

@pablogsal

pablogsal commented Oct 15, 2019

Copy link
Copy Markdown
Member Author

Thanks @tirkarthi :)

@pablogsal
pablogsal merged commit f3ef06a into python:master Oct 15, 2019
@pablogsal
pablogsal deleted the bpo-38478 branch October 15, 2019 11:40
@miss-islington

miss-islington commented Oct 15, 2019

Copy link
Copy Markdown
Contributor

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@bedevere-bot

bedevere-bot commented Oct 15, 2019

Copy link
Copy Markdown

GH-16801 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 15, 2019
@pablogsal @miss-islington
bpo-38478: Correctly handle keyword argument with same name as positi…
52bc3fa 
…onal-only parameter (pythonGH-16800)

(cherry picked from commit f3ef06a)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
miss-islington added a commit that referenced this pull request Oct 15, 2019
@miss-islington @pablogsal
bpo-38478: Correctly handle keyword argument with same name as positi…
f705f8e 
…onal-only parameter (GH-16800)

(cherry picked from commit f3ef06a)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
@pablogsal

pablogsal commented Oct 15, 2019

Copy link
Copy Markdown
Member Author

The buildbot failure is unrelated: test_start_tls_server_1

@python python deleted a comment from bedevere-bot Oct 15, 2019
@python python deleted a comment from bedevere-bot Oct 15, 2019
@bedevere-bot

bedevere-bot commented Oct 15, 2019

Copy link
Copy Markdown

jacobneiltaylor pushed a commit to jacobneiltaylor/cpython that referenced this pull request Dec 5, 2019
@pablogsal Jake Taylor
bpo-38478: Correctly handle keyword argument with same name as positi…
e70edd7 
…onal-only parameter (pythonGH-16800)
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
@pablogsal @shihai1991
bpo-38478: Correctly handle keyword argument with same name as positi…
1423392 
…onal-only parameter (pythonGH-16800)
@jacobtylerwalls jacobtylerwalls mentioned this pull request Apr 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tirkarthi tirkarthi tirkarthi approved these changes

Assignees

@pablogsal pablogsal

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@pablogsal @miss-islington @bedevere-bot @tirkarthi @the-knights-who-say-ni