gh-87106: Fix `inspect.signature.bind` handling of positional-only arguments with `**kwargs` by jacobtylerwalls · Pull Request #103404 · python/cpython · GitHub
Skip to content

gh-87106: Fix inspect.signature.bind handling of positional-only arguments with **kwargs - #103404

Merged
serhiy-storchaka merged 17 commits into
python:mainfrom
jacobtylerwalls:issue-87106
May 13, 2024
Merged

gh-87106: Fix inspect.signature.bind handling of positional-only arguments with **kwargs#103404
serhiy-storchaka merged 17 commits into
python:mainfrom
jacobtylerwalls:issue-87106

Conversation

@jacobtylerwalls

@jacobtylerwalls jacobtylerwalls commented Apr 10, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

gh-87106
Closes #87106

If a function signature has a variadic keyword argument (like **kwargs), then providing a keyword with the same name as a positional-only argument will still succeed, and become available on kwargs.

Before
inspect.signature(f).bind(pos_only='val') might either:

  • raise TypeError unnecessarily if the positional-only arg had a default
  • raise TypeError with a different flavor of error message than runtime (runtime mentions the missing positional arg, but bind() mentioned the name collision, which wasn't the problem)

Now
These are fixed.

Prior related work
#16800

@bedevere-bot bedevere-bot mentioned this pull request Apr 10, 2023
Closed
sobolevn
sobolevn reviewed Apr 10, 2023
View reviewed changes

@sobolevn sobolevn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Comment thread Lib/test/test_inspect.py Outdated
Comment thread Lib/test/test_inspect.py
@sobolevn
sobolevn requested a review from larryhastings April 10, 2023 06:44
@sobolevn sobolevn mentioned this pull request Apr 15, 2023
Closed
@jacobtylerwalls
jacobtylerwalls requested a review from sobolevn July 23, 2023 23:59
@jacobtylerwalls

jacobtylerwalls commented May 4, 2024

Copy link
Copy Markdown
Contributor Author

sobolevn
sobolevn reviewed May 5, 2024
View reviewed changes

@sobolevn sobolevn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with the fix in general. However, there are still some things to polish and improve :)

Thanks a lot for your work!

Comment thread Lib/test/test_inspect/test_inspect.py
Comment thread Lib/test/test_inspect/test_inspect.py Outdated
Comment thread Lib/inspect.py Outdated
Comment thread Lib/inspect.py Outdated
Comment thread Lib/inspect.py Outdated
jacobtylerwalls
jacobtylerwalls commented May 5, 2024
View reviewed changes
Comment thread Lib/inspect.py
@jacobtylerwalls
jacobtylerwalls requested a review from sobolevn May 5, 2024 15:15
@jacobtylerwalls

jacobtylerwalls commented May 5, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Thanks for your suggestions, @sobolevn. Should I move some of the new cases to test_signature_bind_posonly_kwargs()?

sobolevn
sobolevn approved these changes May 9, 2024
View reviewed changes

@sobolevn sobolevn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@serhiy-storchaka do you have any additional feedback?

@serhiy-storchaka
serhiy-storchaka self-requested a review May 9, 2024 13:17
serhiy-storchaka
serhiy-storchaka reviewed May 9, 2024
View reviewed changes
Comment thread Lib/test/test_inspect/test_inspect.py Outdated
Comment thread Lib/test/test_inspect/test_inspect.py Outdated
Comment thread Lib/inspect.py Outdated
Comment thread Lib/inspect.py
serhiy-storchaka
serhiy-storchaka reviewed May 10, 2024
View reviewed changes
Comment thread Lib/test/test_inspect/test_inspect.py Outdated
Comment thread Lib/inspect.py
serhiy-storchaka
serhiy-storchaka approved these changes May 12, 2024
View reviewed changes

@serhiy-storchaka serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@serhiy-storchaka
serhiy-storchaka merged commit 9c15202 into python:main May 13, 2024
@serhiy-storchaka serhiy-storchaka added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels May 13, 2024
@miss-islington-app

miss-islington-app Bot commented May 13, 2024

Copy link
Copy Markdown

Thanks @jacobtylerwalls for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@miss-islington-app

miss-islington-app Bot commented May 13, 2024

Copy link
Copy Markdown

Thanks @jacobtylerwalls for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 13, 2024
@jacobtylerwalls @miss-islington
pythongh-87106: Fix inspect.signature.bind() handling of positional-o…
4c23ae3 
…nly arguments with **kwargs (pythonGH-103404)

(cherry picked from commit 9c15202)

Co-authored-by: Jacob Walls <jacobtylerwalls@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 13, 2024
@jacobtylerwalls @miss-islington
pythongh-87106: Fix inspect.signature.bind() handling of positional-o…
256c4be 
…nly arguments with **kwargs (pythonGH-103404)

(cherry picked from commit 9c15202)

Co-authored-by: Jacob Walls <jacobtylerwalls@gmail.com>
@bedevere-app

bedevere-app Bot commented May 13, 2024

Copy link
Copy Markdown

GH-118984 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label May 13, 2024
@bedevere-app

bedevere-app Bot commented May 13, 2024

Copy link
Copy Markdown

@bedevere-app bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label May 13, 2024
serhiy-storchaka pushed a commit that referenced this pull request May 13, 2024
@miss-islington @jacobtylerwalls
[3.12] gh-87106: Fix inspect.signature.bind() handling of positional-…
35649df 
…only arguments with **kwargs (GH-103404) (GH-118984)

(cherry picked from commit 9c15202)

Co-authored-by: Jacob Walls <jacobtylerwalls@gmail.com>
serhiy-storchaka pushed a commit that referenced this pull request May 13, 2024
@miss-islington @jacobtylerwalls
[3.13] gh-87106: Fix inspect.signature.bind() handling of positional-…
a8ea966 
…only arguments with **kwargs (GH-103404) (#118985)

(cherry picked from commit 9c15202)

Co-authored-by: Jacob Walls <jacobtylerwalls@gmail.com>
@JelleZijlstra JelleZijlstra mentioned this pull request May 28, 2024
Closed
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@jacobtylerwalls @estyxx
pythongh-87106: Fix inspect.signature.bind() handling of positional-o…
8786b75 
…nly arguments with **kwargs (pythonGH-103404)
@hoodmane hoodmane mentioned this pull request Nov 6, 2024
Merged
6 tasks
@dfremont dfremont mentioned this pull request Feb 15, 2025
Closed
@jacobtylerwalls
jacobtylerwalls deleted the issue-87106 branch February 15, 2025 23:42
@jacobtylerwalls jacobtylerwalls mentioned this pull request Feb 17, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes
@sobolevn sobolevn sobolevn approved these changes
@larryhastings larryhastings Awaiting requested review from larryhastings

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Incorrect behavior of inspect.signature(f).bind

4 participants

@jacobtylerwalls @serhiy-storchaka @sobolevn @bedevere-bot