bpo-33610: When toggling code-context on, immediately show the current context. by taleinat · Pull Request #14821 · python/cpython · GitHub
Skip to content

bpo-33610: When toggling code-context on, immediately show the current context. #14821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
terryjreedy merged 4 commits into from
Jul 18, 2019
Merged

bpo-33610: When toggling code-context on, immediately show the current context. #14821

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4d3ee3c
When toggling code-context on, immediately show the current context.
taleinat Jul 17, 2019
d75c69b
reset code context to its initial state when toggling off
taleinat Jul 18, 2019
ac3f4dc
expand toggling tests to cover newly fixed issues
taleinat Jul 18, 2019
1849713
add NEWS entry
taleinat Jul 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions Lib/idlelib/codecontext.py
View file
Open in desktop
17 changes: 14 additions & 3 deletions Lib/idlelib/idle_test/test_codecontext.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ def test_toggle_code_context_event(self):
toggle()

# Toggle on.
eq(toggle(), 'break')
toggle()
self.assertIsNotNone(cc.context)
eq(cc.context['font'], self.text['font'])
eq(cc.context['fg'], self.highlight_cfg['foreground'])
Expand All @@ -145,11 +145,22 @@ def test_toggle_code_context_event(self):
eq(self.root.tk.call('after', 'info', self.cc.t1)[1], 'timer')

# Toggle off.
eq(toggle(), 'break')
toggle()
self.assertIsNone(cc.context)
eq(cc.editwin.label, 'Show Code Context')
self.assertIsNone(self.cc.t1)

# Scroll down and toggle back on.
line11_context = '\n'.join(x[2] for x in cc.get_context(11)[0])
cc.text.yview(11)
toggle()
eq(cc.context.get('1.0', 'end-1c'), line11_context)

# Toggle off and on again.
toggle()
toggle()
eq(cc.context.get('1.0', 'end-1c'), line11_context)

def test_get_context(self):
eq = self.assertEqual
gc = self.cc.get_context
Expand Down Expand Up @@ -329,7 +340,7 @@ def test_font(self):
eq = self.assertEqual
cc = self.cc
save_font = cc.text['font']
test_font = 'TkFixedFont'
test_font = 'TkTextFont'

# Ensure code context is not active.
if cc.context is not None:
Expand Down
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/IDLE/2019-07-18-10-11-36.bpo-33610.xYqMLg.rst
View file
Open in desktop