{{ message }}
bpo-33610: When toggling code-context on, immediately show the current context. - #14821
Merged
terryjreedy merged 4 commits intoJul 18, 2019
Merged
Conversation
This avoids a delay of up to 100ms and the accompanying visual artifact.
taleinat
added
skip news
needs backport to 3.7
performance
Member
Contributor
Author
|
@terryjreedy, I've pushed a fix for the issue of wrong context shown after toggling off and back on. This was actually an entirely separate issue. I've also added tests for both issues. |
taleinat
added
type-bug
terryjreedy
approved these changes
Jul 18, 2019
terryjreedy
left a comment
terryjreedy
left a comment
Member
There was a problem hiding this comment.
Problem fixed. There is an issue with flashing (window manager clearing an area before overwriting it) when CC is in 'add' mode, versus 'sub' mode. Another reason to force CC into 'sub' mode. Nothing I tried made a definite improvement, so I am merging now, so we can move on.
Contributor
|
Thanks @taleinat for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 18, 2019
…ly (pythonGH-14821) Eliminate delay of up to 100ms and accompanying visual artifact. Fix bug of never showing context when hide and show. (cherry picked from commit e0a1f8f) Co-authored-by: Tal Einat <taleinat@gmail.com>
|
GH-14846 is a backport of this pull request to the 3.8 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 18, 2019
…ly (pythonGH-14821) Eliminate delay of up to 100ms and accompanying visual artifact. Fix bug of never showing context when hide and show. (cherry picked from commit e0a1f8f) Co-authored-by: Tal Einat <taleinat@gmail.com>
lisroach
pushed a commit
to lisroach/cpython
that referenced
this pull request
Sep 10, 2019
…ly (pythonGH-14821) Eliminate delay of up to 100ms and accompanying visual artifact. Fix bug of never showing context when hide and show.
DinoV
pushed a commit
to DinoV/cpython
that referenced
this pull request
Jan 14, 2020
…ly (pythonGH-14821) Eliminate delay of up to 100ms and accompanying visual artifact. Fix bug of never showing context when hide and show.
websurfer5
pushed a commit
to websurfer5/cpython
that referenced
this pull request
Jul 20, 2020
…ly (pythonGH-14821) Eliminate delay of up to 100ms and accompanying visual artifact. Fix bug of never showing context when hide and show.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This avoids a delay of up to 100ms and the accompanying visual artifact.
https://bugs.python.org/issue33610