GH-73991: Make `pathlib.Path.delete()` private. by barneygale · Pull Request #123315 · python/cpython · GitHub
Skip to content

GH-73991: Make pathlib.Path.delete() private. - #123315

Merged
barneygale merged 2 commits into
python:mainfrom
barneygale:gh-73991-private-delete
Aug 26, 2024
Merged

barneygale merged 2 commits into
python:mainfrom
barneygale:gh-73991-private-delete

Conversation

@barneygale

@barneygale barneygale commented Aug 25, 2024

Copy link
Copy Markdown
Contributor

Per feedback from Paul Moore on GH-123158, it's better to defer making Path.delete() public than ship it with under-designed error handling capabilities.

We leave a remnant _delete() method, which is used by move(). Any functionality not needed by move() is deleted.


📚 Documentation preview 📚: https://cpython-previews--123315.org.readthedocs.build/

Per feedback from Paul Moore on pythonGH-123158, it's better to defer making
`Path.delete()` public than ship it with under-designed error handling
capabilities.

We leave a remnant `_delete()` method, which is used by `move()`. Any
functionality not needed by `move()` is deleted.
@barneygale

barneygale commented Aug 25, 2024

Copy link
Copy Markdown
Contributor Author

@barneygale
barneygale requested a review from pfmoore August 25, 2024 17:32
@pfmoore

pfmoore commented Aug 25, 2024

Copy link
Copy Markdown
Member

@barneygale
barneygale merged commit 033d537 into python:main Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants