{{ message }}
GH-73991: Prune pathlib.Path.delete() arguments - #123158
Closed
barneygale wants to merge 5 commits into
Closed
Conversation
Remove the *ignore_errors* and *on_error* arguments from `Path.delete()`. This functionality was carried over from `shutil`, but its design needs to be re-considered in its new context. For example, we may wish to support a *missing_ok* argument (like `Path.unlink()`), or automatically `chmod()` and retry operations when we hit a permission error (like `tempfile.TemporaryDirectory`), or retry operations with a backoff (like `test.support.os_helper.rmtree()`), or utilise exception groups, etc. It's best to leave our options open for now.
pathlib.Path.delete()pathlib.Path.delete() arguments
Member
Contributor
Author
|
Thanks very much, that's most helpful. I'll close this PR for now, and open a new topic on the forum (in a few weeks time) about what to do with these arguments. I'll try to make the case that the number of practical |
barneygale
added a commit
to barneygale/cpython
that referenced
this pull request
Aug 25, 2024
Per feedback from Paul Moore on pythonGH-123158, it's better to defer making `Path.delete()` public than ship it with under-designed error handling capabilities. We leave a remnant `_delete()` method, which is used by `move()`. Any functionality not needed by `move()` is deleted.
barneygale
added a commit
that referenced
this pull request
Aug 26, 2024
Per feedback from Paul Moore on GH-123158, it's better to defer making `Path.delete()` public than ship it with under-designed error handling capabilities. We leave a remnant `_delete()` method, which is used by `move()`. Any functionality not needed by `move()` is deleted.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Remove the ignore_errors and on_error arguments from
Path.delete(). This functionality was carried over fromshutil.rmtree(), but its design needs to be re-evaluated in its new context. Some possible alternate designs:Path.unlink())chmod()and retry operations when we hit a permission error (liketempfile.TemporaryDirectory)test.support.os_helper.rmtree()),It's best to leave our options open for now. I don't want to risk these arguments landing in 3.14 final because I got hit by a bus or something.
No news because
Path.delete()remains unreleased.📚 Documentation preview 📚: https://cpython-previews--123158.org.readthedocs.build/