gh-111201: Skip pyrepl Windows tests earlier by vstinner · Pull Request #119848 · python/cpython · GitHub
Skip to content

gh-111201: Skip pyrepl Windows tests earlier - #119848

Merged
vstinner merged 1 commit into
python:mainfrom
vstinner:pyrepl_testwin
May 31, 2024
Merged

gh-111201: Skip pyrepl Windows tests earlier#119848
vstinner merged 1 commit into
python:mainfrom
vstinner:pyrepl_testwin

Conversation

@vstinner

@vstinner vstinner commented May 31, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

Don't attempt to load pyrepl Windows console if platforms others than Windows. For example, the import can fail if ctypes is missing.

@bedevere-app bedevere-app Bot added tests Tests in the Lib/test dir awaiting core review labels May 31, 2024
@bedevere-app bedevere-app Bot mentioned this pull request May 31, 2024
Closed
7 tasks
@vstinner vstinner changed the title gh-111201: Skip pyperl Windows tests earlier gh-111201: Skip pyrepl Windows tests earlier May 31, 2024
@vstinner

vstinner commented May 31, 2024

Copy link
Copy Markdown
Member Author

@vstinner
pythongh-111201: Skip pyrepl Windows tests earlier
b3a16bc 
Don't attempt to load pyrepl Windows console if platforms others than
Windows. For example, the import can fail if ctypes is missing.
@vstinner
vstinner enabled auto-merge (squash) May 31, 2024 13:50
@vstinner
vstinner merged commit 91601a5 into python:main May 31, 2024
@vstinner
vstinner deleted the pyrepl_testwin branch May 31, 2024 14:06
@AlexWaygood

AlexWaygood commented May 31, 2024

Copy link
Copy Markdown
Member

FYI, I think that that buildbot failure was already fixed an hour ago, in #119834

@vstinner vstinner mentioned this pull request May 31, 2024
Merged
vstinner added a commit to vstinner/cpython that referenced this pull request Jun 1, 2024
@vstinner
pythongh-111201: Skip pyrepl Windows tests earlier (python#119848)
8806c0c 
Don't attempt to load pyrepl Windows console if platforms others than
Windows. For example, the import can fail if ctypes is missing.

(cherry picked from commit 91601a5)
@bedevere-app

bedevere-app Bot commented Jun 1, 2024

Copy link
Copy Markdown

vstinner added a commit that referenced this pull request Jun 1, 2024
@vstinner
[3.13] gh-111201: Skip pyrepl Windows tests earlier (#119848) (#119924)
ac35d96 
gh-111201: Skip pyrepl Windows tests earlier (#119848)

Don't attempt to load pyrepl Windows console if platforms others than
Windows. For example, the import can fail if ctypes is missing.

(cherry picked from commit 91601a5)
noahbkim pushed a commit to hudson-trading/cpython that referenced this pull request Jul 11, 2024
@vstinner @noahbkim
pythongh-111201: Skip pyrepl Windows tests earlier (python#119848)
94f63ff 
Don't attempt to load pyrepl Windows console if platforms others than
Windows. For example, the import can fail if ctypes is missing.
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@vstinner @estyxx
pythongh-111201: Skip pyrepl Windows tests earlier (python#119848)
bb58e4a 
Don't attempt to load pyrepl Windows console if platforms others than
Windows. For example, the import can fail if ctypes is missing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal pablogsal approved these changes
@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner
@ambv ambv Awaiting requested review from ambv ambv is a code owner

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vstinner @AlexWaygood @pablogsal