gh-111201: [pyrepl] Ensure optional platform-specific imports are optional by ambv · Pull Request #119834 · python/cpython · GitHub
Skip to content

gh-111201: [pyrepl] Ensure optional platform-specific imports are optional - #119834

Merged
ambv merged 1 commit into
python:mainfrom
ambv:gh-119559-followup
May 31, 2024
Merged

gh-111201: [pyrepl] Ensure optional platform-specific imports are optional#119834
ambv merged 1 commit into
python:mainfrom
ambv:gh-119559-followup

Conversation

@ambv

@ambv ambv commented May 31, 2024

Copy link
Copy Markdown
Contributor

This is a followup from gh-119559.

@bedevere-app bedevere-app Bot added tests Tests in the Lib/test dir awaiting core review labels May 31, 2024
@ambv ambv added skip news and removed tests Tests in the Lib/test dir awaiting core review labels May 31, 2024
@bedevere-app bedevere-app Bot mentioned this pull request May 31, 2024
7 tasks
@ambv ambv added the topic-repl Related to the interactive shell label May 31, 2024
@ambv

ambv commented May 31, 2024

Copy link
Copy Markdown
Contributor Author

@bedevere-bot

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @ambv for commit 5ce516b 🤖

The command will test the builders whose names match following regular expression: AMD64 FreeBSD14

The builders matched are:

  • AMD64 FreeBSD14 PR

@ambv
ambv merged commit 4c387a7 into python:main May 31, 2024
@ambv ambv added the needs backport to 3.13 bugs and security fixes label May 31, 2024
@miss-islington-app

Copy link
Copy Markdown

Thanks @ambv for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@miss-islington-app

Copy link
Copy Markdown

Sorry, @ambv, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 4c387a76f3ac8509c29634f4bbda6c37a67550d5 3.13

@ambv

ambv commented May 31, 2024

Copy link
Copy Markdown
Contributor Author

Actually, no. I will backport this as part of the gh-119559 backport.

@ambv
ambv deleted the gh-119559-followup branch May 31, 2024 12:42
@ambv ambv removed the needs backport to 3.13 bugs and security fixes label May 31, 2024
ambv added a commit to miss-islington/cpython that referenced this pull request May 31, 2024
@vstinner

Copy link
Copy Markdown
Member

@ambv: Oh, I wrote a different fix for a similar issue: PR gh-119848. Should I backport it to 3.13?

@bedevere-bot

Copy link
Copy Markdown

@ambv
ambv restored the gh-119559-followup branch May 31, 2024 16:35
noahbkim pushed a commit to hudson-trading/cpython that referenced this pull request Jul 11, 2024
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@ambv
ambv deleted the gh-119559-followup branch October 7, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip news topic-repl Related to the interactive shell

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants