Integrate `node-streams-aff` into library by JordanMartinez · Pull Request #52 · purescript-node/purescript-node-streams · GitHub
Skip to content

Integrate node-streams-aff into library #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JordanMartinez merged 10 commits into from
Jul 8, 2023
Merged

Integrate node-streams-aff into library #52

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
9d5ba69
Copy over Node.Stream.Aff as-is
JordanMartinez Jul 7, 2023
10c7e19
Update code for breaking changes
JordanMartinez Jul 7, 2023
68960e3
Simplify usage of `readable`
JordanMartinez Jul 7, 2023
438dd99
Copy over tests as-is, renaming Main.purs
JordanMartinez Jul 8, 2023
8401b98
Get tests to compile and pass
JordanMartinez Jul 8, 2023
94ba77f
Update CI
JordanMartinez Jul 8, 2023
410ed1a
Format docs
JordanMartinez Jul 8, 2023
ff6411c
Add changelog entry
JordanMartinez Jul 8, 2023
18245a6
Add missing dependency on aff
JordanMartinez Jul 8, 2023
b3a8730
Update pulp to 16.0.2; fix CI usage of pulp
JordanMartinez Jul 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
17 changes: 17 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,22 @@ New features:
- pipeline
- fromString, fromBuffer
- newPassThrough
- Integrated `node-streams-aff` into library (#52 by @JordanMartinez)

Convenience APIs added for readable streams in "paused" mode:
- readSome
- readAll
- readN

Convenience APIs for writeable streams:
- write
- end

Convenience APIs for converting `String`s from/to `Array Buffer`
- toStringUTF8
- fromStringUTF8

The only APIs from the library not added were `newReadable` and `push`.

Bugfixes:
- Drop misleading comment for `setEncoding` (#51 by @JordanMartinez)
Expand All @@ -65,6 +81,7 @@ Other improvements:
- Refactor tests using `passThrough` streams (#49 by @JordanMartinez)
- Updated FFI to use uncurried functions (#50 by @JordanMartinez)
- Relocated `setEncoding`, `Read`, and `Write` for better locality in docs (#51 by @JordanMartinez)
- Added `node-streams-aff` tests (#52 by @JordanMartinez)

## [v7.0.0](https://github.com/purescript-node/purescript-node-streams/releases/tag/v7.0.0) - 2022-04-29

Expand Down
6 changes: 4 additions & 2 deletions bower.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,8 @@
"devDependencies": {
"purescript-assert": "^6.0.0",
"purescript-console": "^6.0.0",
"purescript-partial": "^4.0.0"
"purescript-partial": "^4.0.0",
"purescript-spec": "^7.3.0"
},
"dependencies": {
"purescript-effect": "^4.0.0",
Expand All @@ -23,6 +24,7 @@
"purescript-node-buffer": "^9.0.0",
"purescript-nullable": "^6.0.0",
"purescript-prelude": "^6.0.0",
"purescript-node-event-emitter": "https://github.com/purescript-node/purescript-node-event-emitter.git#^3.0.0"
"purescript-node-event-emitter": "https://github.com/purescript-node/purescript-node-event-emitter.git#^3.0.0",
"purescript-aff": "^7.1.0"
}
}
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Loading