{{ message }}
Integrate node-streams-aff into library#52
Merged
JordanMartinez merged 10 commits intomasterfrom Jul 8, 2023
Merged
Conversation
Contributor
Author
Member
Great, thanks. I'll check this out later. |
Contributor
Author
|
@jamesdbrock Have you had a chance to review this? Since this repo hasn't had a new release yet, it's blocking the other work I've done. |
Member
|
Yeah looks great. I see you've swapped in all the new EventEmitter stuff and you've got all the tests passing. |
Member
|
The foreign imports in the tests is weird though, why was that necessary? Can't those foreign imports be imported instead from other purescript-node packages? |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
Copies
node-streams-affand its tests into this library, excluding two APIs:newReadableandpush. I think that function could be better supported to allow for custom streams, but I didn't port that or implement my own version for two reasons:Readablefrom aString, which has been supported viafromString.@jamesdbrock, can you take a look at this?
Checklist: