load modules concurrently #4545 by roryc89 · Pull Request #4549 · purescript/purescript · GitHub
Skip to content

load modules concurrently #4545 #4549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
roryc89 wants to merge 2 commits into
base: master
Choose a base branch
from
+10 −6
Open

load modules concurrently #4545 #4549

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
92fb93e
load modules concurrently #4545
roryc89 Aug 1, 2024
6fb43a4
read ide files concurrently
roryc89 Aug 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/Language/PureScript/Ide.hs
View file
Open in desktop
6 changes: 4 additions & 2 deletions src/Language/PureScript/Ide/SourceFile.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,8 @@ import Language.PureScript.CST qualified as CST
import Language.PureScript.Ide.Error (IdeError)
import Language.PureScript.Ide.Types (DefinitionSites, IdeNamespace(..), IdeNamespaced(..), TypeAnnotations)
import Language.PureScript.Ide.Util (ideReadFile)
import Control.Concurrent.Async.Lifted (mapConcurrently)
import Control.Monad.Trans.Control (MonadBaseControl)
Comment on lines +32 to +33

@rhendric rhendric Sep 21, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same nit.


parseModule :: FilePath -> Text -> Either FilePath (FilePath, P.Module)
parseModule path file =
Expand All @@ -37,11 +39,11 @@ parseModule path file =
Right m -> Right (path, m)

parseModulesFromFiles
:: (MonadIO m, MonadError IdeError m)
:: (MonadIO m, MonadBaseControl IO m, MonadError IdeError m)
=> [FilePath]
-> m [Either FilePath (FilePath, P.Module)]
parseModulesFromFiles paths = do
files <- traverse ideReadFile paths
files <- mapConcurrently ideReadFile paths
pure (inParallel (map (uncurry parseModule) files))
where
inParallel :: [Either e (k, a)] -> [Either e (k, a)]
Expand Down
3 changes: 2 additions & 1 deletion src/Language/PureScript/Ide/Types.hs
View file
Open in desktop