{{ message }}
load modules concurrently #4545#4549
Open
roryc89 wants to merge 2 commits into
Open
Conversation
f-f
approved these changes
Aug 23, 2024
Member
|
We'll need another review from the core team - could anyone take a look? |
rhendric
reviewed
Sep 21, 2024
rhendric
left a comment
rhendric
left a comment
Member
There was a problem hiding this comment.
Nits aside, I'm surprised that this is reported to decrease memory use because my understanding is that mapConcurrently will spawn every one of these tasks at once. Has that been confirmed on very large projects? What about consumption of other resources—open file handles or something?
I'd be more comfortable with this if we used primitives like pooledMapConcurrently instead. OTOH, I don't do much maintenance of the Ide modules so if the team members who do are happy with this I won't block it.
| import Language.PureScript.Ide.Usage (findUsages) | ||
| import System.Directory (getCurrentDirectory, getDirectoryContents, doesDirectoryExist, doesFileExist) | ||
| import System.FilePath ((</>), normalise) | ||
| import Control.Concurrent.Async.Lifted (mapConcurrently, mapConcurrently_) |
Member
There was a problem hiding this comment.
Nit: insert into the imports in alphabetical order, please.
Comment on lines
+32
to
+33
| import Control.Concurrent.Async.Lifted (mapConcurrently) | ||
| import Control.Monad.Trans.Control (MonadBaseControl) |
| import Language.PureScript qualified as P | ||
| import Language.PureScript.Errors.JSON qualified as P | ||
| import Language.PureScript.Ide.Filter.Declaration (DeclarationType(..)) | ||
| import Control.Monad.Trans.Control (MonadBaseControl) |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
On large projects loading the modules concurrently lowers memory usage substantially. Should help address #4545
Checklist:
Relevant checklist points addressed in #4546