Percentages have a range of 0-100 now by bouwew · Pull Request #923 · plugwise/python-plugwise · GitHub
Skip to content

Percentages have a range of 0-100 now - #923

Merged
bouwew merged 7 commits into
mainfrom
valve-percentage
Sep 22, 2026
Merged

Percentages have a range of 0-100 now#923
bouwew merged 7 commits into
mainfrom
valve-percentage

Conversation

@bouwew

@bouwew bouwew commented Sep 22, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Bug Fixes
    • Improved percentage handling for values represented on a 0–100 scale.
    • Correctly processes zero percentages and truncates larger percentage readings for compatibility with older firmware.
  • Tests
    • Updated device data and test fixtures to use consistent integer representations for whole-number valve positions and modulation levels.
  • Documentation
    • Added a changelog entry documenting the percentage-format compatibility fix.

@coderabbitai

coderabbitai Bot commented Sep 22, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

@codecov

codecov Bot commented Sep 22, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (760ac5e) to head (ff648ba).

Additional details and impacted files 
@@            Coverage Diff            @@
##              main      #923   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           21        21           
  Lines         3514      3516    +2     
=========================================
+ Hits          3514      3516    +2

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@coderabbitai
coderabbitai Bot requested a review from CoMPaTech September 22, 2026 06:07
@bouwew
bouwew marked this pull request as ready for review September 22, 2026 06:12
@bouwew
bouwew requested a review from a team as a code owner September 22, 2026 06:12
@sonarqubecloud

sonarqubecloud Bot commented Sep 22, 2026

Copy link
Copy Markdown

@bouwew
bouwew merged commit 7005920 into main Sep 22, 2026
18 checks passed
@bouwew
bouwew deleted the valve-percentage branch September 22, 2026 16:54
@bouwew bouwew mentioned this pull request Sep 22, 2026
Closed

This branch was successfully deployed

2 active deployments
pypi — ff648bac Deployed Sep 22, 2026 by bouwew via Build and publish Python 🐍 distributions 📦 to PyPI #815
testpypi — ff648bac Deployed Sep 22, 2026 by bouwew via Build and publish Python 🐍 distributions 📦 to TestPyPI #6425
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CoMPaTech CoMPaTech CoMPaTech approved these changes
@coderabbitai coderabbitai[bot] coderabbitai[bot] approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bouwew @CoMPaTech