{{ message }}
Repository navigation
Fix Core Issue #178699 - #914
Merged
Merged
Conversation
Contributor
coderabbitai
Bot
added
enhancement
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@CHANGELOG.md`:
- Line 5: Update the changelog entry to replace the misspelled “confort” with
“comfort,” leaving the rest of the entry unchanged.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 2c7e57cc-7277-4287-8391-d7c0f543d6b4
📒 Files selected for processing (2)
CHANGELOG.mdplugwise/smile.py
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #914 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 21 21
Lines 3505 3506 +1
=========================================
+ Hits 3505 3506 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
coderabbitai
Bot
removed
enhancement
coderabbitai
Bot
added
enhancement
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@plugwise/smile.py`:
- Around line 271-277: Update the validation checks in the methods handling dhw,
gateway, and regulation modes to safely handle missing optional collections by
using an empty-list fallback before membership tests. Preserve the existing
PlugwiseError behavior for unsupported modes or invalid lengths, and apply this
consistently to dhw_modes, gateway_modes, and regulation_modes.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: a1ef5b94-c79c-4b53-a5df-6188e00720e7
📒 Files selected for processing (2)
plugwise/helper.pyplugwise/smile.py
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
New Features
Bug Fixes
Documentation