Remove `routes-compiler-injected-routes-compilation-with-request-passed` scripted test as duplicate by ihostage · Pull Request #13231 · playframework/playframework · GitHub
Skip to content

Remove routes-compiler-injected-routes-compilation-with-request-passed scripted test as duplicate#13231

Open
ihostage wants to merge 1 commit intoplayframework:mainfrom
ihostage:drop-routes-compiler-injected-routes-compilation-with-request-passed
Open

Remove routes-compiler-injected-routes-compilation-with-request-passed scripted test as duplicate#13231
ihostage wants to merge 1 commit intoplayframework:mainfrom
ihostage:drop-routes-compiler-injected-routes-compilation-with-request-passed

Conversation

@ihostage
Copy link
Copy Markdown
Member

@ihostage ihostage commented Apr 4, 2025

I think routes-compiler-injected-routes-compilation-with-request-passed already covered by routes-compiler-routes-compilation and routes-compiler-routes-compilation-java.

I added a few cases related the name, type and position of Request param into routes-compiler-routes-compilation-java. Therefore, I think we don't need this duplicated test now.

@mkurz
Copy link
Copy Markdown
Member

mkurz commented Jun 6, 2025

@ihostage
Copy link
Copy Markdown
Member Author

ihostage commented Jun 9, 2025

@ihostage ihostage force-pushed the drop-routes-compiler-injected-routes-compilation-with-request-passed branch from 56d7a18 to 9f423a2 Compare October 20, 2025 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 👀 In review

Development

Successfully merging this pull request may close these issues.

2 participants