{{ message }}
Remove routes-compiler-injected-routes-compilation scripted test as duplicate#13230
Open
ihostage wants to merge 1 commit intoplayframework:mainfrom
Open
Remove routes-compiler-injected-routes-compilation scripted test as duplicate#13230ihostage wants to merge 1 commit intoplayframework:mainfrom
routes-compiler-injected-routes-compilation scripted test as duplicate#13230ihostage wants to merge 1 commit intoplayframework:mainfrom
Conversation
ihostage
commented
Apr 4, 2025
Member
Author
There was a problem hiding this comment.
This case is covered by routes-compiler-routes-compilation-java
41 tasks
ihostage
force-pushed
the
drop-routes-compiler-injected-routes-compilation
branch
from
335d689 to
33277b5
Compare
ihostage
commented
Apr 4, 2025
| GET /take-list controllers.Application.takeList(x: List[Int]) | ||
| GET /take-list-tick-param controllers.Application.takeListTickedParam(`b[]`: List[Int]) | ||
| GET /take-java-list controllers.Application.takeJavaList(x: java.util.List[java.lang.Integer]) | ||
| GET /take-ticked-params controllers.Application.takeTickedParams(`b[]`: List[Int], `b%%`: String) |
Member
Author
There was a problem hiding this comment.
This case was moved to routes-compiler-routes-compilation-java
Comment on lines
-43
to
-46
| it("should properly escape the host", function() { | ||
| var data = jsRoutesBadHost.controllers.Application.index(); | ||
| assert(data.absoluteURL().indexOf("'}}};alert(1);a={a:{a:{a:'") >= 0) | ||
| }); |
Member
Author
There was a problem hiding this comment.
This check was moved to routes-compiler-routes-compilation
Comment on lines
-110
to
-119
Member
Author
There was a problem hiding this comment.
This check was moved to routes-compiler-routes-compilation
ihostage
force-pushed
the
drop-routes-compiler-injected-routes-compilation
branch
from
33277b5 to
0b1f871
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
StaticRoutesGeneratorwas removed more than 7 years ago (#8049) andInjectedRoutesGeneratorhas become the only possible way. Therefore, I see no reason to have a two very similar scripted tests.After analysing the difference between
routes-compiler-injected-routes-compilationandroutes-compiler-routes-compilationfolders I copied some cases that were not covered byroutes-compiler-routes-compilationand completely removedroutes-compiler-injected-routes-compilation.