sbt-header plugins should handle md files in docs project by mkurz · Pull Request #11245 · playframework/playframework · GitHub
Skip to content

sbt-header plugins should handle md files in docs project#11245

Merged
mkurz merged 1 commit into
playframework:mainfrom
mkurz:docs_md_header
Apr 19, 2022
Merged

sbt-header plugins should handle md files in docs project#11245
mkurz merged 1 commit into
playframework:mainfrom
mkurz:docs_md_header

Conversation

@mkurz

@mkurz mkurz commented Apr 19, 2022

Copy link
Copy Markdown
Member

Makes the ancient addMarkdownCopyright script obsolete so we can remove it in #11142, since we have the sbt-header plugin now.
The empty line gets added by default when running headerCreateAll. We could set headerEmptyLine := false, however that does not really help, since there are many java and scala files which do have the empty line, meaning now these would be modified, this time automatically removing the empty line by the sbt-header plugin.

Comment thread documentation/build.sbt

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I opened sbt/sbt-header#285 to simplify the CommentStyle config even more.

@mkurz

mkurz commented Apr 19, 2022

Copy link
Copy Markdown
Member Author

@mkurz mkurz merged commit 4a5e3ce into playframework:main Apr 19, 2022
@mkurz mkurz deleted the docs_md_header branch April 19, 2022 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant