iframe-proxy

ihostage · 2022-02-02T13:46:34Z

Notes by @mkurz:
Using coursier/cache-action without arguments will build a hash from the content of these files and uses that hash as part of the key to store the values (paths/files).
That means to "invalidate" the cache the build.sbt, project/[*.scala|*.sbt], etc. has to change.

When extracing the cache, existing files in a path will be kept, except for files which also exist in the stored cache, then it will be overwritten. In the background a tar command is used: tar -xf <archive.tar> -P -C <dir>

Right now, the cache content is not updated. That means e.g. once the .cache/coursier folder is cached, it will never be updated anymore if there was a cache hit (with the primary key): actions/cache#342
Also see here: https://github.com/actions/cache/blob/8f1e2e02865c42348f9baddbbaafb1841dce610a/src/save.ts#L38 - when the primary key is hit, the cache will never be updated.

The cache-hit output will only be set to true, if there was an exact match: https://github.com/actions/cache/blob/8f1e2e02865c42348f9baddbbaafb1841dce610a/src/restore.ts#L52 (there could also be a partial match, but then still the output will be false)
BTW: Here is the underlying restoreCache method used: https://github.com/actions/toolkit/blob/91f9153ca87feb260480640429822005380ea9de/packages/cache/src/cache.ts#L65 (the saveCache is below it as well)

coursier/cache-action and coursier/setup-action play well together to cache a java installation. That's because cs uses ~/.cache/coursier/, e.g. ~/.cache/coursier/https/github.com/adoptium/temurin11-binaries/releases/download/jdk-11.0.14.1%252B1/OpenJDK11U-jdk_x64_linux_hotspot_11.0.14.1_1.tar.gz/jdk-11.0.14.1+1, see https://github.com/playframework/playframework/runs/6110556466?check_suite_focus=true#step:6:49
Problem: When using different JVM, only one will cached by default when the first jobs runs, because like written above the cache is not going to be updated. Fixed in the prefetch-for-caching job.

Stupid workaround to clear the cache: actions/cache#2 (comment) (Can be combined with inputs: https://github.blog/changelog/2020-07-06-github-actions-manual-triggers-with-workflow_dispatch). Added the workaround for the Play repo here: #11247

A travis config we used to test different sbt and scala versions, including running some of the jobs in a cron job:
https://github.com/playframework/playframework/blob/f18c239c9186b5b65af291817cd75918f5d39ff9/.travis.yml

…still needed)

"needs" is used to build a dependency graph, not always to wait for lightweight jobs

mkurz · 2022-04-24T18:27:55Z

mkurz

Finally.

mkurz · 2022-04-24T18:44:44Z

+  prefetch-for-caching:
+    name: Prefetch dependencies and JVMs for caching
+    uses: playframework/.github/.github/workflows/sbt.yml@v1
+    # if: steps.coursier-cache.outputs.cache-hit-coursier != 'true' # Waiting for https://github.com/coursier/cache-action/pull/296


Actually this condition here will be very important to speed up the build. Right now this prefetch job will always run all sbt commands below, however once that feature is available that job will be run only one time for each unique file hash of the build.sbt and project/[*.sbt|*.scala]
That means as long as that sbt files do not change, we will always reuse the same cache which is quite nice.

mkurz · 2022-04-24T19:57:23Z

FYI: It seems the workaround removed in this commit 5f38e1d will not be necessary for when using GitHub actions 👍 It seems GHA is smarter than travis was and will always check out the same commit, even when a pull request gets merged e.g. between the first job and the last job (for example after the publish local job finished and before a scripted test jobs starts. In Travis CI this caused problems because we used dynver and now the commit sha changed between the two jobs, the dynver play version changed as well, so the published artifacts could not be used in the scripted tests).
I just tested this with #11231, where I cancelled the scripted test jobs, merged a pull request, and then again started the jobs. The jobs worked correctly and also the "Checkout" job still used the same commit sha like the publish local one. Nice.

mkurz · 2022-04-25T05:02:25Z

The first nightly failed: https://github.com/playframework/playframework/actions/runs/2217931578
I will investigate...

ihostage · 2022-04-25T11:43:48Z

It also turns out that we do not need the script folder anymore.

Not quite 😄 local-pr-validation.sh is used by contributors and is mentioned in CONTRIBUTING.md 😉
I think we can create the same simple script without using scripts/scriptLib.

mkurz · 2022-04-25T11:46:55Z

local-pr-validation.sh is now replace by simply running sbt validateCode, I think we should just update the docs and tell people to make use of that sbt task instead of adding scripts for that. (Mentioned that in commit message of 5af610b)

mkurz · 2022-04-25T11:51:10Z

@ihostage see #11250. Thanks for reviewing 👍

PromanSEW · 2022-05-04T15:06:11Z

This PR was not correctly squashed and "littered" main branch a lot :-/

mkurz · 2022-05-04T15:07:57Z

🤔 Hmm, that depends, some people like to squash and rebase, some people like to merge and keep the whole history. It's a matter of taste and what someone prefers.

PromanSEW · 2022-05-04T15:13:07Z

Other PRs were always squashed and merged as 1 commit with PR link, weren't are?

mkurz · 2022-05-04T15:13:58Z

ihostage added the status:block-merge label Feb 2, 2022

ihostage mentioned this pull request Feb 2, 2022

Migrate to GitHub Actions playframework/play-meta#204

Closed

23 tasks

ihostage force-pushed the github-actions branch from f6b9dc2 to a22b0b4 Compare February 2, 2022 13:53

ihostage marked this pull request as draft February 2, 2022 13:56

ihostage force-pushed the github-actions branch 8 times, most recently from a58e6a4 to 10f755c Compare February 2, 2022 20:01

mkurz reviewed Feb 2, 2022

View reviewed changes

Comment thread .github/workflows/build-test.yml Outdated

ihostage force-pushed the github-actions branch 8 times, most recently from f64fbe3 to 26ead0d Compare February 3, 2022 21:14

ihostage mentioned this pull request Feb 7, 2022

Workflows improvements (ENVs, Caches, Include/Exclude) playframework/.github#4

Merged

mkurz mentioned this pull request Apr 11, 2022

Switch to reusable workflows playframework/play-ws#670

Merged

ihostage force-pushed the github-actions branch 2 times, most recently from cdca0d3 to 565e021 Compare April 11, 2022 20:55

ihostage commented Apr 19, 2022

View reviewed changes

Comment thread .github/workflows/build-test.yml Outdated

ihostage commented Apr 19, 2022

View reviewed changes

Comment thread .github/workflows/build-test.yml

mkurz mentioned this pull request Apr 19, 2022

sbt-header plugins should handle md files in docs project #11245

Merged

mkurz force-pushed the github-actions branch 2 times, most recently from e852bee to 0672aea Compare April 21, 2022 09:40

mkurz force-pushed the github-actions branch from a5bd232 to 0185e7f Compare April 24, 2022 09:51

mkurz added 12 commits April 24, 2022 11:54

Moved to GHA: Publish local with Java 11

d07461e

This moved to GHA already

c1d7e23

This script is not in use since a004ae6

a5a1976

This script is obsolete now, just use "sbt validateCode"

5af610b

These moved to the workflows in the .github repo

90dc8c8

Remove remaining base script

5b21b61

Remove remaining scripts (we will need to test if that workaround is …

5f38e1d

…still needed)

Remove remaining travis config

f1d89bd

Finish job needs to run only for pull requests

9b603cb

Comment in case we add multiple sbt versions

b12e3bc

Run the nightly job at 4 am UTC

f3ef2e9

Remove comment, its not always accurate

f4ef9ee

"needs" is used to build a dependency graph, not always to wait for lightweight jobs

mkurz force-pushed the github-actions branch from 0185e7f to f4ef9ee Compare April 24, 2022 09:55

mkurz marked this pull request as ready for review April 24, 2022 18:28

mkurz approved these changes Apr 24, 2022

View reviewed changes

mkurz merged commit 877ddc5 into playframework:main Apr 24, 2022

mkurz reviewed Apr 24, 2022

View reviewed changes

ihostage deleted the github-actions branch April 25, 2022 11:38

mkurz mentioned this pull request May 1, 2022

[2.8.x] Switch to GitHub actions #11262

Merged

Sunbelt Computer Software

PL/B Language Development and Support

Uh oh!

Uh oh!

Conversation

ihostage commented Feb 2, 2022 • edited by mkurz Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mkurz commented Apr 24, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mkurz left a comment

Choose a reason for hiding this comment

Uh oh!

mkurz Apr 24, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mkurz commented Apr 24, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mkurz commented Apr 25, 2022

Uh oh!

ihostage commented Apr 25, 2022

Uh oh!

mkurz commented Apr 25, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mkurz commented Apr 25, 2022

Uh oh!

PromanSEW commented May 4, 2022

Uh oh!

mkurz commented May 4, 2022

Uh oh!

PromanSEW commented May 4, 2022

Uh oh!

mkurz commented May 4, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ihostage commented Feb 2, 2022 •

edited by mkurz

Loading

mkurz commented Apr 24, 2022 •

edited

Loading

mkurz Apr 24, 2022 •

edited

Loading

mkurz commented Apr 24, 2022 •

edited

Loading

mkurz commented Apr 25, 2022 •

edited

Loading

mkurz commented May 4, 2022 •

edited

Loading