Correct nullability annotations in OIDEndSessionRequest by philet · Pull Request #702 · openid/AppAuth-iOS · GitHub
Skip to content

Correct nullability annotations in OIDEndSessionRequest - #702

Open
philet wants to merge 2 commits into
openid:masterfrom
philet:endsession-request-nullability
Open

philet wants to merge 2 commits into
openid:masterfrom
philet:endsession-request-nullability

Conversation

@philet

@philet philet commented Apr 8, 2022 •

Copy link
Copy Markdown

Correct nullability annotations for OIDEndSessionRequest parameters idTokenHint, postLogoutRedirectURL, and state.

Fixes #565

@petea

petea commented Apr 8, 2022

Copy link
Copy Markdown
Collaborator

@philet

philet commented Apr 11, 2022

Copy link
Copy Markdown
Author

@petea I have signed them last Friday. Probably still needs to be processed on your side.

@petea

petea commented Aug 16, 2022

Copy link
Copy Markdown
Collaborator

@philet confirmed that we have the needed documentation from you, thanks.

@petea petea changed the title Correct nullability for OIDEndSessionRequest parameters idTokenHint, … Correct nullability annotations in OIDEndSessionRequest Aug 16, 2022
@petea

petea commented Aug 16, 2022

Copy link
Copy Markdown
Collaborator

Since this will be a breaking change for the Swift interface, we'll need to make it as part of a major release.

@petea petea added this to the 2.0.0 milestone Aug 16, 2022
@nbransby

nbransby commented Nov 4, 2022

Copy link
Copy Markdown

@petea since its only adding the nullability won't existing code still compile meaning its not a breaking change?

@pfei5

pfei5 commented Jan 30, 2023

Copy link
Copy Markdown

We're having to run a fork of this lib because of this issue. Is there anything missing from the PR that we could provide?

@matax87

matax87 commented Aug 7, 2023

Copy link
Copy Markdown

Any update on this?

@trykovyura

Copy link
Copy Markdown

up

@MichaelHackett

Copy link
Copy Markdown

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

OIDEndSessionRequest initializers lack correct nullability specifiers

9 participants