Update parameter nullability by davedelong · Pull Request #566 · openid/AppAuth-iOS · GitHub
Skip to content

Update parameter nullability - #566

Closed
davedelong wants to merge 1 commit into
openid:masterfrom
davedelong:davedelong-endrequest-parameter-nullability
Closed

davedelong wants to merge 1 commit into
openid:masterfrom
davedelong:davedelong-endrequest-parameter-nullability

Conversation

@davedelong

Copy link
Copy Markdown

Fixes #565

@codecov-commenter

Copy link
Copy Markdown

@markusfassbender

markusfassbender commented Nov 23, 2020 •

Copy link
Copy Markdown

Thanks davedelong, it would be great to see this merged!

@petea
petea self-requested a review March 16, 2022 18:10

@petea petea left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@davedelong could you update the nullability annotations for the initializer implementations as well?

@philet

philet commented Apr 7, 2022

Copy link
Copy Markdown

@davedelong could you update the nullability annotations for the initializer implementations as well?

@davedelong If you give me access to the branch for this pull request I could do this update. (I'd be glad to get this pull request merged too.)

@davedelong

Copy link
Copy Markdown
Author

@petea @philet I'm not using this project anymore and am intending to delete my fork just to keep my personal GitHub tidy. You're welcome to copy the diff and re-apply it. All I did was add 5 nullability annotations.

@petea petea added this to the 2.0.0 milestone Apr 7, 2022
@philet

philet commented Apr 8, 2022

Copy link
Copy Markdown

@davedelong davedelong closed this by deleting the head repository Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

OIDEndSessionRequest initializers lack correct nullability specifiers

5 participants