{{ message }}
MAINT: Use spin lint in CI#25103
Merged
Merged
Conversation
ganesh-k13
commented
Nov 10, 2023
ganesh-k13
left a comment
ganesh-k13
left a comment
Member
Author
There was a problem hiding this comment.
Need to add spin as a lint requirement now. Would it make sense to merge linter_requirements.txt with build_requirements.txt now? Since lint checks should technically be part of the development workflow?
Member
Member
|
+1 for keeping separate, |
ganesh-k13
force-pushed
the
ci_24080_1
branch
from
bcabf55 to
e716d50
Compare
Member
Author
ganesh-k13
force-pushed
the
ci_24080_1
branch
from
17ee666 to
e716d50
Compare
seberg
reviewed
Nov 15, 2023
ganesh-k13
force-pushed
the
ci_24080_1
branch
2 times, most recently
from
f172c7f to
79e72dd
Compare
Member
|
@ganesh-k13 will you be continuing with this? There are merge conflicts |
Member
Author
|
Yeah, I'll look into it to see if it's still a valid enhancement this week. |
ganesh-k13
force-pushed
the
ci_24080_1
branch
from
79e72dd to
2814d15
Compare
ganesh-k13
force-pushed
the
ci_24080_1
branch
2 times, most recently
from
e6c5b07 to
07ea700
Compare
- use `spin lint` for CI - use `spin notes` for CI
ganesh-k13
force-pushed
the
ci_24080_1
branch
from
07ea700 to
1ed690f
Compare
ganesh-k13
commented
Jan 30, 2026
ganesh-k13
force-pushed
the
ci_24080_1
branch
from
1ed690f to
c204338
Compare
Member
Author
|
Circle CI is passing as well |
ganesh-k13
added
58 - Ready for review
component: CI
and removed
01 - Enhancement
labels
mattip
reviewed
Feb 3, 2026
| . venv/bin/activate | ||
| VERSION=$(pip show numpy | grep Version: | cut -d ' ' -f 2 | cut -c 1-5) | ||
| spin notes --version-override $VERSION | ||
|
|
Member
There was a problem hiding this comment.
I think spin docs creates the release notes, no?
Member
Author
There was a problem hiding this comment.
I did a simple check:
$ spin docs -j8
Invoking `build` prior to building docs:
$ /<>/Documents/os/np-test/bin/python3 vendored-meson/meson/meson.py compile -C build
INFO: autodetecting backend as ninja
...
$ git status
On branch main
Your branch is up to date with 'origin/main'.
nothing to commit, working tree clean
$ spin notes
Generating release notes for NumPy 2.5.0.dev0
Reading upcoming changes from doc/release/upcoming_changes/
$ towncrier build --version 2.5.0.dev0 --yes
Loading template...
Finding news fragments...
Rendering news fragments...
...
$ git status
On branch main
Your branch is up to date with 'origin/main'.
Changes to be committed:
(use "git restore --staged <file>..." to unstage)
deleted: doc/release/upcoming_changes/29536.deprecation.rst
deleted: doc/release/upcoming_changes/30181.deprecation.rst
deleted: doc/release/upcoming_changes/30340.expired.rst
deleted: doc/release/upcoming_changes/30381.new_feature.rst
deleted: doc/release/upcoming_changes/30460.expired.rst
deleted: doc/release/upcoming_changes/30461.expired.rst
deleted: doc/release/upcoming_changes/30462.expired.rst
deleted: doc/release/upcoming_changes/30463.expired.rst
deleted: doc/release/upcoming_changes/30467.expired.rst
deleted: doc/release/upcoming_changes/30480.typing.rst
deleted: doc/release/upcoming_changes/30489.compatibility.rst
deleted: doc/release/upcoming_changes/30517.performance.rst
deleted: doc/release/upcoming_changes/30538.change.rst
deleted: doc/release/upcoming_changes/30566.typing.rst
deleted: doc/release/upcoming_changes/30604.expired.rst
deleted: doc/release/upcoming_changes/30605.deprecation.rst
deleted: doc/release/upcoming_changes/30610.expired.rst
deleted: doc/release/upcoming_changes/30612.expired.rst
deleted: doc/release/upcoming_changes/30613.expired.rst
deleted: doc/release/upcoming_changes/30614.expired.rst
deleted: doc/release/upcoming_changes/30644.deprecation.rst
deleted: doc/release/upcoming_changes/30653.new_feature.rst
deleted: doc/release/upcoming_changes/30707.change.rst
The release notes are not getting generated in spin docs
Member
Author
There was a problem hiding this comment.
But this is interesting
Lines 115 to 117 in dd6a3ad
Member
Author
There was a problem hiding this comment.
Ok so --keep and --draft (ref) does not write to the output files. But it gets the checks done and will fail if there are errors. So we can remove this.
mattip
changed the title
spin commands for CIspin commands for CI
Member
sabasiddique1
pushed a commit
to sabasiddique1/numpy
that referenced
this pull request
Feb 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
spin lintfor CIuse spin notes for CITesting
Notes
spincommands for developer workflow #24080lintspin command #24983ENH: Addednotescommand for spin #25017