ENH: Added a `lint` spin command by ganesh-k13 · Pull Request #24983 · numpy/numpy · GitHub
Skip to content

ENH: Added a lint spin command#24983

Merged
rgommers merged 4 commits into
numpy:mainfrom
ganesh-k13:bld_24080_lint
Oct 24, 2023
Merged

ENH: Added a lint spin command#24983
rgommers merged 4 commits into
numpy:mainfrom
ganesh-k13:bld_24080_lint

Conversation

@ganesh-k13

@ganesh-k13 ganesh-k13 commented Oct 22, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

Changes

Added a lint spin command

Testing

Basic

~/os/numpy (main*) » spin lint --uncommitted                                                                                                                                ganesh@ganesh-MS-7B86
Performing lint checks for uncommitted changes
./numpy/testing/overrides.py:11:80: E501 line too long (114 > 79 characters)
./numpy/testing/overrides.py:66:80: E501 line too long (110 > 79 characters)
2       E501 line too long (114 > 79 characters)
                                                                                                                                         
                                                                                                 
(np-test) ------------------------------------------------------------------------------------------------------------------------------------------------------------------------
~/os/numpy (main*) » echo $?                                                                                                                                            1 ↵ ganesh@ganesh-MS-7B86
1

Module not found:

(np-test) ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
~/os/numpy (bld_24080_lint*) » spin lint --uncommitted                                                                                                                                                          ganesh@ganesh-MS-7B86
Performing lint checks for uncommitted changes
Error: No module named 'git'. Install using linter_requirements.txt

Notes

Related: #24080

@ganesh-k13 ganesh-k13 self-assigned this Oct 22, 2023
@charris charris changed the title DEV: Added a lint spin command ENH: Added a lint spin command Oct 22, 2023
rgommers
rgommers reviewed Oct 23, 2023
View reviewed changes

@rgommers rgommers left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, thanks Ganesh! It looks ready to me, modulo the docs.

The gdb issue is probably you having an old version of spin installed? It works for me with version 0.7

Comment thread .spin/cmds.py Outdated
Comment thread .spin/cmds.py Outdated
@ganesh-k13 ganesh-k13 marked this pull request as ready for review October 23, 2023 10:27
rgommers
rgommers reviewed Oct 23, 2023
View reviewed changes
Comment thread .spin/cmds.py
@charris

charris commented Oct 24, 2023

Copy link
Copy Markdown
Member

rgommers
rgommers reviewed Oct 24, 2023
View reviewed changes
Comment thread .spin/cmds.py Outdated
@rgommers rgommers added this to the 2.0.0 release milestone Oct 24, 2023
rgommers
rgommers approved these changes Oct 24, 2023
View reviewed changes

@rgommers rgommers left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now, in it goes. Thanks @ganesh-k13

@rgommers rgommers merged commit 9f6789c into numpy:main Oct 24, 2023
@ganesh-k13 ganesh-k13 mentioned this pull request Nov 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rgommers rgommers rgommers approved these changes

Assignees

@ganesh-k13 ganesh-k13

Labels

01 - Enhancement 16 - Development component: build

Projects

None yet

Milestone

2.0.0 release

Development

Successfully merging this pull request may close these issues.

3 participants

@ganesh-k13 @charris @rgommers