{{ message }}
Repository navigation
Conversation
The test only needs one request data chunk to queue the server write and destroy the client stream. Using a persistent data listener can queue multiple writes and multiple destroys from the same request body, which makes the test occasionally hang until the harness timeout. Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: openai:gpt-5.5
nodejs-github-bot
added
needs-ci
trivikr
added
the
request-ci
Contributor
I don't really follow the logic, how scheduling multiple destroy would result in a hang? That sounds like a bug |
Member
Author
|
You're right. I should have searched for test-http2-close-while-writing before attempting this PR which would have helped me discover prior attempts. I've been following that in my latest 5 PRs. |
Member
Author
|
I've posted a bugfix attempt in https://www.github.com/nodejs/node/pull/63439, and will request review after GitHub CI is successful. |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes
test-http2-close-while-writinghandle only the first server-siderequest data chunk.
The test only needs one chunk to exercise the regression path: the server queues
a write, then the client stream is destroyed on the next tick. Keeping the data
listener active can queue multiple writes and schedule multiple destroys for the
same request body, which makes the test occasionally hang until the harness
timeout.
Refs: https://github.com/nodejs/reliability/blob/main/reports/2026-05-17.md#jstest-failure
Assisted-by: openai:gpt-5.5