`parallel/test-http2-close-while-writing` is flaky · Issue #58252 · nodejs/node · GitHub
Skip to content

parallel/test-http2-close-while-writing is flaky #58252

Closed
#66016
Closed
parallel/test-http2-close-while-writing is flaky#58252
#66016
Labels
flaky-testIssues and PRs involving tests that fail intermittently in CI.macosIssues and PRs related to the macOS platform.never-staleIssues and PRs exempt from automated stale handling.

Description

@lpinca
lpinca
opened on May 9, 2025

Test

test-http2-close-while-writing

Platform

macOS x64

Console output

---
duration_ms: 120080.257
exitcode: -15
severity: fail
stack: timeout
...

Build links

Additional information

I can reproduce the issue locally via

$ python3 tools/test.py --repeat=10000 parallel/test-http2-close-while-writing

$ lldb -p 79156
(lldb) process attach --pid 79156
Process 79156 stopped
* thread #1, name = 'MainThread', queue = 'com.apple.main-thread', stop reason = signal SIGSTOP
    frame #0: 0x00007ff80b21281e libsystem_kernel.dylib`kevent + 10
libsystem_kernel.dylib`kevent:
->  0x7ff80b21281e <+10>: jae    0x7ff80b212828 ; <+20>
    0x7ff80b212820 <+12>: movq   %rax, %rdi
    0x7ff80b212823 <+15>: jmp    0x7ff80b20e2a2 ; cerror_nocancel
    0x7ff80b212828 <+20>: retq   
Target 0: (node) stopped.
Executable binary set to "/Users/luigi/code/node/out/Release/node".
Architecture set to: x86_64-apple-macosx-.
(lldb) bt
* thread #1, name = 'MainThread', queue = 'com.apple.main-thread', stop reason = signal SIGSTOP
  * frame #0: 0x00007ff80b21281e libsystem_kernel.dylib`kevent + 10
    frame #1: 0x000000010543d4ec node`uv__io_poll(loop=<unavailable>, timeout=<unavailable>) at kqueue.c:286:12 [opt]
    frame #2: 0x0000000105429280 node`uv_run(loop=0x0000000109b4d530, mode=UV_RUN_DEFAULT) at core.c:460:5 [opt]
    frame #3: 0x00000001044e6663 node`node::SpinEventLoopInternal(env=0x00007f80ee009600) at embed_helpers.cc:41:7 [opt]
    frame #4: 0x00000001046072bd node`node::NodeMainInstance::Run() [inlined] node::NodeMainInstance::Run(this=<unavailable>, exit_code=<unavailable>, env=0x00007f80ee009600) at node_main_instance.cc:110:9 [opt]
    frame #5: 0x0000000104607229 node`node::NodeMainInstance::Run(this=<unavailable>) at node_main_instance.cc:99:3 [opt]
    frame #6: 0x0000000104591aef node`node::Start(int, char**) [inlined] node::StartInternal(argc=<unavailable>, argv=<unavailable>) at node.cc:1545:24 [opt]
    frame #7: 0x0000000104591aa4 node`node::Start(argc=<unavailable>, argv=<unavailable>) at node.cc:1552:27 [opt]
    frame #8: 0x00007ff80aeab530 dyld`start + 3056

Activity

  1. lpinca
    added
    flaky-testIssues and PRs involving tests that fail intermittently in CI.
    on May 9, 2025
  2. github-actions
    added
    macosIssues and PRs related to the macOS platform.
    on May 9, 2025

  3. lpinca commented on May 9, 2025

    @lpinca
    lpinca
    on May 9, 2025
    MemberAuthor

    This callback

    node/test/parallel/test-http2-close-while-writing.js

    Line 40 in 264cad7

    is called when the test times out.

  4. lpinca commented on May 10, 2025

    @lpinca
    lpinca
    on May 10, 2025
    MemberAuthor

    I don't think the original intention was to call stream.write(Buffer.alloc(1)) for each received chunk, and the following patch fixes the issue

    diff --git a/test/parallel/test-http2-close-while-writing.js b/test/parallel/test-http2-close-while-writing.js
index d8537c31b00..231bf712d40 100644
--- a/test/parallel/test-http2-close-while-writing.js
+++ b/test/parallel/test-http2-close-while-writing.js
@@ -23,8 +23,8 @@ let client_stream;
 
 server.on('session', common.mustCall(function(session) {
   session.on('stream', common.mustCall(function(stream) {
-    stream.resume();
-    stream.on('data', function() {
+    stream.once('data', function() {
+      this.resume();
       this.write(Buffer.alloc(1));
       process.nextTick(() => client_stream.destroy());
     });

    However it is not clear to me why the stream sometimes hangs. The reason for the hang/timeout is that this callback

    node/lib/internal/http2/core.js

    Lines 2192 to 2196 in 6710c00

    is not called.

    I'm not opening a PR with the patch because it would hide the bug.

    cc: @nodejs/http2

  5. mcollina
    added a commit that references this issue on Feb 14, 2026

    http2: invoke pending write callback on stream destroy

    c16f526

  6. github-actions commented on Apr 20, 2026

    @github-actions
    github-actionsBot
    on Apr 20, 2026 – with GitHub Actions
    Contributor

    This issue has been marked as stale due to 210 days of inactivity.
    It will be automatically closed in 30 days if no further activity occurs. If this is still relevant, please leave a comment or update it to keep it open.

  7. github-actions
    added
    staleIssues and PRs marked stale due to inactivity and scheduled for automatic closure.
    on Apr 20, 2026
  8. lpinca
    added
    never-staleIssues and PRs exempt from automated stale handling.
    and removed
    staleIssues and PRs marked stale due to inactivity and scheduled for automatic closure.
    on Apr 20, 2026

  9. lpinca commented on Apr 20, 2026

    @lpinca
    lpinca
    on Apr 20, 2026
    MemberAuthor

    It is still relevant.

  10. lpinca commented on Jun 1, 2026

    @lpinca
    lpinca
    on Jun 1, 2026
    MemberAuthor

    Fixed by 5f96180.

  11. lpinca
    closed this as completedon Jun 1, 2026

  12. inoway46 commented on Sep 12, 2026

    @inoway46
    inoway46
    on Sep 12, 2026
    Contributor

    This seems to be flaky again. The recent failures appear to have the same signature as the original report (timeout after ~120s):

  13. inoway46
    reopened this on Sep 12, 2026
  14. mcollina
    added 2 commits that reference this issue on Sep 13, 2026

    http2: settle pending write callbacks on stream destroy

    2e34a6f

    http2: settle pending write callbacks on destroy

    9d88a60
  15. nodejs-github-bot
    added a commit that references this issue on Sep 15, 2026

    http2: settle pending write callbacks on destroy

    e13c138
  16. nodejs-github-bot
    closed this as completedin #66016on Sep 15, 2026
  17. aduh95
    added 4 commits that reference this issue on Sep 16, 2026

    http2: settle pending write callbacks on destroy

    c864c90

    http2: settle pending write callbacks on destroy

    46f76ed

    http2: settle pending write callbacks on destroy

    5b379ef

    http2: settle pending write callbacks on destroy

    8921108
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    flaky-testIssues and PRs involving tests that fail intermittently in CI.macosIssues and PRs related to the macOS platform.never-staleIssues and PRs exempt from automated stale handling.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions